Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Remove Bluebird: phase 1 #3612

Merged
merged 8 commits into from
Nov 14, 2019
Merged

Remove Bluebird: phase 1 #3612

merged 8 commits into from
Nov 14, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 12, 2019

Replaces:

  • Promise.defer with regular promises in most places and with a small defer shim elsewhere
  • Promise.delay with a sleep utils method

Adds promise utils module

Subset of #3593
@t3chguy t3chguy requested a review from a team November 12, 2019 12:11
@dbkr dbkr requested review from dbkr and removed request for a team November 13, 2019 10:07
dbkr
dbkr reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
@t3chguy
Remove unused promise utils method
bc90789 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from dbkr November 14, 2019 00:40
@t3chguy
re-add and actually use promise timeout util
5c24547 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy mentioned this pull request Nov 14, 2019
Merged
@t3chguy t3chguy merged commit 58d15ac into develop Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@t3chguy @dbkr