This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Show verification requests in the timeline #3601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
as we will have 2 tiles, and both need to track the status of the verification request, I've put the logic for tracking the state in this helper class to use from both tiles.
only if the request was send by or to us, otherwise ignore.
don't render any done events not sent by us, as done events are sent by both parties and we don't want to render two conclusion tiles. cancel events should be only sent by one party.
bwindels force-pushed the bwindels/verification-over-dm branch from fd56f3e to 805c837 Compare 
dbkr approved these changes Nov 8, 2019
This was referenced Nov 8, 2019
turt2live added a commit that referenced this pull request Nov 8, 2019
Redacted messages do not have message types, despite being room messages. Fixes element-hq/element-web#11352 Regressed in #3601 Click-to-ping being broken (as mentioned by element-hq/element-web#11353) is a side effect of the react stack falling over. Once one room crashes, click-to-ping is broken everywhere.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implements element-hq/element-web#11251
Requires: matrix-org/matrix-js-sdk#1067
This PR implements sending verification requests over direct messages, which can be enabled with the
feature_dm_verificationfeature flag. Verification is still initiated through the usualDeviceVerifyDialogdialog, e.g. by clicking "verify" next to a device in the member info. Reworking that will come in a later PR.During verification, two tiles are shown in the timeline: one for the request (the
m.key.verification.requestevent), and one for the conclusion (eitherm.key.verification.cancelorm.key.verification.doneevent), as per the design. All the events have anm.referencerelationship with the first request event (see spec), so I put the code to monitor all of this as events come in inKeyVerificationStateObserveras both theMKeyVerificationRequestandMKeyVerificationConclusionneed to be aware of the current state of the request.The styling for both tiles is identical, so I just called the classes
mx_KeyVerificationto share them between the two components for lack of a better idea, even though that doesn't really follow our guidelines. Feel free to suggest a better idea for this.The "bubble" style adds an alternative layout for an event tile, using css grid to overlap the container where the bubble is centered with the timestamp on the left and the read receipts on the right. The bubble doesn't actually visually overlap as it is is centered and has a max-width.