Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add a prompt when interacting with an identity server without terms #3582

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Add a prompt when interacting with an identity server without terms #3582

merged 2 commits into from
Nov 1, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Oct 31, 2019

This adds a prompt whenever we are about to perform some action on a default identity
server (from homeserver .well-known or Riot app config) without terms. This
allows the user to abort or trust the server (storing it in account data).

Fixes element-hq/element-web#10557
@jryans jryans requested a review from a team October 31, 2019 13:06
@jryans
Add a prompt when interacting with an identity server without terms
0fc5108 
This adds a prompt whenever we are about to perform some action on a default identity server (from homeserver .well-known or Riot app config) without terms. This allows the user to abort or trust the server (storing it in account data). Fixes element-hq/element-web#10557
@jryans jryans force-pushed the jryans/prompt-when-no-terms branch from 281f21c to 0fc5108 Compare October 31, 2019 13:13
turt2live
turt2live approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, though the code is getting a bit fiddly to keep track of.
@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

the code is getting a bit fiddly to keep track of

Yes, I definitely agree... 😓
@jryans jryans merged commit dd5702f into develop Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@jryans @turt2live