This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix error message which is shown when unknown slash command attempted #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jryans approved these changes Oct 31, 2019
| // assume the error is a server error when the command is async | ||
| const isServerError = !!cmd.promise; | ||
| const title = isServerError ? "Server error" : "Command error"; | ||
| const title = isServerError ? _td("Server error") : _td("Command error"); |
There was a problem hiding this comment.
Why do you need _td for this case?
There was a problem hiding this comment.
just to get rid of the duplication of the ternary statement with the same strings, it has to go untranslated to the Modal constructor for Telemetry/Piwik but then translated to be rendered to the user, so I do the ternary once on the marked-as-translatable-but-english-string then pass to Modal then translate it for rendering without two ternaries
There was a problem hiding this comment.
Okay, thanks for the explanation. I missed the analytics bit of the tangle. (Might be nice to have "Slash Commands" somewhere in the analytics data.)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11269