This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Don't intercept TAB on the app outside of the composer, fix tabIndex > 0 #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
jryans approved these changes Oct 10, 2019
bwindels approved these changes Oct 10, 2019
| ); | ||
| | ||
| return <div className="mx_TopLeftMenu mx_HiddenFocusable" tabIndex={0} ref={this.props.containerRef}> | ||
| return <div className="mx_TopLeftMenu" ref={this.props.containerRef}> |
There was a problem hiding this comment.
I guess tabIndex was removed on purpose here, to rather allow to navigate to elements inside the left panel?
There was a problem hiding this comment.
Yup, to the elements inside the Menu itself, focusing on the entire menu wasn't the most useful
| ah, ryan already beat me to it :) |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
outline: nonestyling (only show outline when navigating using keyboard)Signed-off-by: Michael Telatynski 7t3chguy@gmail.com