This repository was archived by the owner on Sep 11, 2024. It is now read-only.
SettingsFlag always run ToggleSwitch fully-controlled #3541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
The SettingsStore is more reliable than the cached value. Some settings also go through a dialog process, which can revert them. In an effort to make sure the toggle reverts correctly (switches back), it is controlled by the settings store. |
| Sure, except here nothing is triggering a re-render so the SettingsStore never gets queried again and thus we end up with stuck toggles |
turt2live suggested changes Oct 9, 2019
turt2live added the X-Release-Blocker Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live approved these changes Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I do not understand why the value would ever come from the SettingsStore directly when we already had a copy of it. If Travis can explain why this is a thing that'd be great.
Fixes issue with preferences not toggling in v1.5.0-rc1
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com