Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

React error/warning cleanup #3529

Merged
merged 3 commits into from
Oct 9, 2019
Merged

React error/warning cleanup #3529

merged 3 commits into from
Oct 9, 2019

Conversation

@t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 8, 2019

  • Transitions some components from componentWillMount to componentDidMount where it makes sense
  • adds required id prop to instance of <Field
  • fixes syntax of allowFullscreen
  • Rewrite ToggleSwitch as a Fully controlled functional component as an example of good React practices (it had derived state for partially uncontrolled behaviour which was not used anywhere)
  • Fixes some javascript:; anchors which React complained will be unsupported

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com
t3chguy added 3 commits October 8, 2019 12:10
@t3chguy
React error/warning cleanup
a782baf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
tidy ToggleSwitch
a03e9e7 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
export ToggleSwitch
4c82496 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team October 8, 2019 18:05
bwindels
bwindels approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
@t3chguy t3chguy merged commit ff18a04 into develop Oct 9, 2019
@tplk tplk mentioned this pull request Oct 9, 2019
Closed
@t3chguy t3chguy deleted the t3chguy/react16_cleanup2 branch April 27, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@t3chguy @bwindels