Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Label submit button in UI auth password prompt #3527

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Label submit button in UI auth password prompt #3527

merged 1 commit into from
Oct 7, 2019

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Oct 7, 2019

@dbkr dbkr requested a review from a team October 7, 2019 12:14
turt2live
turt2live approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs a yarn i18n but otherwise lgtm.

Test failures at this time are expected because npm broke.
@dbkr
Copy link
Member Author

dbkr commented Oct 7, 2019

I actually remembered yarn i18n this time but we already had the string 'Continue'.
@dbkr dbkr merged commit c97d1d5 into develop Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@dbkr @turt2live