This repository was archived by the owner on Sep 11, 2024. It is now read-only.
remove ll feature flag, it's time! #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
turt2live approved these changes Feb 7, 2019
| | ||
| _onChange = async (checked) => { | ||
| if (this.props.featureId === "feature_lazyloading") { | ||
| const confirmed = await this._onLazyLoadChanging(checked); |
There was a problem hiding this comment.
if we're dropping the homeserver check, please also delete the function above.
| I once again reviewed a change that wasn't in the queue - sorry :( |
bwindels commented Feb 7, 2019
| also don't forget to run |
| green!!!! \o/ :heavy_check_mark::heavy_check_mark::heavy_check_mark::heavy_check_mark: |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR to update config on develop: https://github.com/matrix-org/internal-config/pull/582
riot-web PR to fix app tests: element-hq/element-web#8464