Remember whether widget drawer was hidden per-room #1533
Conversation
Fixes matrix-org#4850 Signed-off-by: Andrew (anoa) <anoa@openmailbox.org>
Signed-off-by: Andrew (anoa) <anoa@openmailbox.org>
anoadragon453 force-pushed the develop branch from e3dbcca to 9821f0d Compare 
| Thanks for this @anoadragon453 -- This will be a really useful addition. Just a couple of comments. Can you please switch this round such that we are checking for 'hideWidgetDrawer === "true"', rather than 'showWidget == "false"'? The default state should be to show the widget drawer, and this is just adding the ability to suppress it. Hopefully this change will make it a bit clearer. Thanks! |
| console.warn("Key is: " + room.roomId + "_show_widget_drawer"); | ||
| console.warn("showWidget is: " + showWidget); | ||
| | ||
| if (showWidget == "false") { |
There was a problem hiding this comment.
Should be 'showWidget === "false"', to avoid falsy comparison of missing key.
| _shouldShowApps: function(room) { | ||
| if (!BROWSER_SUPPORTS_SANDBOX) return false; | ||
| | ||
| // Check if user has prompted to close this app before |
There was a problem hiding this comment.
Can you please modify this comment to:
// Check if user has previously chosen to hide the app drawer for this room
Signed-off-by: Andrew (anoa) <anoa@openmailbox.org>
anoadragon453 force-pushed the develop branch from a11641f to b4868a6 Compare 
| Removed logs and switched over to the idea of 'hiding' rather than 'not showing'. Let me know if anything else needs to be changed. |
| Thank you guys for some awesome chat software! |
| This all good to go? Eager to use on riot.im at some point :) |
| i don’t know why this hasn’t been merged - @rxl881? |
| /me was just poking for @anoadragon453, not for self |
| @t3chguy Thank you for that! |
| Apologies for the delay in getting this merged @anoadragon453. It has now been merged and should be live on /develop shortly. Thanks again for the contribution! |
| No worries, and thank you! |
5 participants
Fixes element-hq/element-web#4850
Signed-off-by: Andrew (anoa) anoa@openmailbox.org