Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Shuffle GroupView UI #1490

Merged
merged 6 commits into from
Oct 18, 2017
Merged

Shuffle GroupView UI #1490

merged 6 commits into from
Oct 18, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Oct 17, 2017 •
edited
Loading

  • Put invite accept/decline buttons in correct div to align them to the right
  • Move membership section above long description textarea and only show membership settings when editing
  • Add useful functions to GroupView to inspect user flags
  • The "Leave" button is now in the top-right
  • The "Publish" button is not a checkbox

Fixes element-hq/element-web#5304, element-hq/element-web#5220, element-hq/element-web#5210
@lukebarnard1 lukebarnard1 changed the title Luke/groups move buttons Shuffle GroupView UI Oct 17, 2017
turt2live
turt2live reviewed Oct 17, 2017
View reviewed changes
src/i18n/strings/en_EN.json
"Add rooms to this group": "Add rooms to this group",
"Invites sent": "Invites sent",
"Your group invitations have been sent.": "Your group invitations have been sent."
"Your group invitations have been sent.": "Your group invitations have been sent.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to s/group/community as part of this PR? (while you're here)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep the two things separate tbh.
@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Oct 17, 2017
@lukebarnard1 lukebarnard1 merged commit 8c16276 into develop Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@lukebarnard1 @dbkr @turt2live