This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix cypress test for events from unsigned devices #11636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
richvdh added the T-Task 
richvdh commented Sep 20, 2023
| .find(".mx_EventTile_e2eIcon") | ||
| .should("have.class", "mx_EventTile_e2eIcon_warning") | ||
| .should("have.attr", "aria-label", "Encrypted by an unverified user."); | ||
| .should("have.attr", "aria-label", "Encrypted by a device not verified by its owner."); |
There was a problem hiding this comment.
this is the actual fix in this PR
richvdh commented Sep 20, 2023
| cy.get(".mx_EventTile_last") | ||
| .should("contain", "test encrypted from unverified") | ||
| .find(".mx_EventTile_e2eIcon", { timeout: 100000 }) | ||
| .find(".mx_EventTile_e2eIcon") |
There was a problem hiding this comment.
I set this timeout very high when I was debugging and apparently forgot to reduce it.
richvdh commented Sep 20, 2023
Comment on lines +418 to 424
| // some debate over whether this should have a red or a grey shield. Legacy crypto shows a grey shield, | ||
| // Rust crypto a red one. | ||
| cy.get(".mx_EventTile_last") | ||
| .should("contain", "test encrypted from unverified") | ||
| .find(".mx_EventTile_e2eIcon") | ||
| .should("have.class", "mx_EventTile_e2eIcon_normal") | ||
| //.should("have.class", "mx_EventTile_e2eIcon_normal") | ||
| .should("have.attr", "aria-label", "Encrypted by an unknown or deleted device."); |
There was a problem hiding this comment.
this is actually a separate fix, but it's kinda handy to throw into this PR
t3chguy approved these changes Sep 20, 2023
| .should("contain", "test encrypted from unverified") | ||
| .find(".mx_EventTile_e2eIcon") | ||
| .should("have.class", "mx_EventTile_e2eIcon_normal") | ||
| //.should("have.class", "mx_EventTile_e2eIcon_normal") |
There was a problem hiding this comment.
Should this be removed rather than comment out?
There was a problem hiding this comment.
hrm, maybe. I'm trying to highlight the fact that we deliberately aren't testing the class (and also, making it easier to put back once we make our mind up what we're doing).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#11528 updated these tests, but I messed up one of the cases (cf matrix-org/matrix-js-sdk#3743) and didn't think hard enough about what I was doing.
This change is marked as an internal change (Task), so will not be included in the changelog.