Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Convert usePublicRoomDirectory #10162

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Convert usePublicRoomDirectory #10162

merged 2 commits into from
Feb 14, 2023

Conversation

@artcodespace
Copy link
Contributor

@artcodespace artcodespace commented Feb 14, 2023 •
edited
Loading

Converts the tests from enzyme to use renderHook from RTL and sorts out a TS issue in the test file

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.
@artcodespace artcodespace added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 14, 2023
@artcodespace artcodespace marked this pull request as ready for review February 14, 2023 14:44
@artcodespace artcodespace requested a review from a team as a code owner February 14, 2023 14:44
andybalaam
andybalaam approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
@artcodespace artcodespace merged commit 4012f0c into develop Feb 14, 2023
@artcodespace artcodespace deleted the alunturner/enzyme-to-rtl-usePublicRoomDirectory branch February 14, 2023 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

3 participants

@artcodespace @andybalaam