Skip to content

Conversation

benbz
Copy link
Contributor

@benbz benbz commented Feb 5, 2020

Our fork changed how pg_current_wal_lsn is generated, whereas prometheus-community/postgres_exporter/pull/307 exposed the same value as pg_current_wal_lsn_bytes. So we'll need to update any dashboards / alerts

Also remove the need for our fork by pulling matrix-org/postgres_exporter@f77ce19 into queries.yaml

@benbz benbz requested a review from a team February 5, 2020 16:45
Copy link
Contributor

@michaelkaye michaelkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me; worth trying on the smaller hosts for a bit, especially lethe which has none to check it's OK, before deploying to the rest.

Additionally we should avoid deploying this on friday to prevent it interacting with our postgresql cache size changes - we need clean before/after knowledge for that to be monitored safely.

@benbz
Copy link
Contributor Author

benbz commented Feb 5, 2020

Additionally we should avoid deploying this on friday to prevent it interacting with our postgresql cache size changes - we need clean before/after knowledge for that to be monitored safely.

I'm going to avoid merging & deploying this at all prior to Friday - given we're going to be running postgres playbooks and it could be difficult to skip this change if it is merged and checked out on ansible box

@michaelkaye
Copy link
Contributor

Also before deployment, NB we inlined this.

@benbz benbz merged commit a4e1f73 into master Feb 11, 2020
@benbz benbz deleted the bbz/use-upstream branch February 11, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants