Skip to content

Conversation

dklilley
Copy link
Member

This change enables navigation between files within a package structure.

Consider the following file structure:

  • +package1
    • +package2
      • func2.m
    • func1.m
  • myScript.m

From within myScript.m, navigation works as expected to either package1.func1 or package1.package2.func2.
However, navigation does not work from func1.m to package1.package2.func2.

This change modifies where we temporarily CD to when trying to resolve identifiers. Instead of CDing to the source file's directory, we CD to the top level directory outside the package structure.

For example, if the source file is at C:\path\to\+my\+package\foo.m, then we CD to C:\path\to.

@dklilley dklilley requested a review from gauravsavadi June 27, 2023 15:40
@dklilley dklilley self-assigned this Jun 27, 2023
@dklilley dklilley merged commit 8df780c into main Jun 27, 2023
@dklilley dklilley deleted the dlilley.bugfix_improve_navigation branch June 28, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants