Clear linting diagnostics & fix launching w/ onDemand setting #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dklilley changed the title | }) | ||
| } | ||
| | ||
| clearDiagnosticsForDocument (textDocument: TextDocument): void { |
There was a problem hiding this comment.
Consider passing just the uri here.
There was a problem hiding this comment.
I had considered this, but decided on passing the TextDocument for two reasons:
- I think this makes the API a bit more readable (clearing diagnostics for a document vs. a URI)
- This matches the other APIs in the file (
queueLintingForDocumentandlintDocument)
| | ||
| // No active connection - should create a connection if desired | ||
| if (await this._isMatlabConnectionTimingNever()) { | ||
| if (!(await this._isMatlabConnectionTimingNever())) { |
There was a problem hiding this comment.
Does this require a comment explaining the change?
There was a problem hiding this comment.
I don't believe so. This bug was introduced by some refactoring in #1, so this change is simply correcting the if-statement.
gauravsavadi approved these changes May 31, 2023
jdhameli approved these changes May 31, 2023
diningPhilosopher64 pushed a commit to diningPhilosopher64/MATLAB-language-server that referenced this pull request Jul 2, 2024
…ment Features: Linting (with quick fixes) and Format Document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change resolves two bugs:
MATLAB Connection Timingsetting is set toonDemand