Fixes for import pattern

[watermarkhu]

The current regex for the meta.import.matlab scope has bugs with regard to import wildcards and trailing whitespaces. The following illustration from regex101 shows the whitespaces better.

For the wildcard itself there already exists a nested scope variable.language.wildcard.matlab:

MATLAB-Language-grammar/Matlab.tmbundle/Syntaxes/MATLAB.tmLanguage

Line 1783 in 33f9678

<string>\*</string>

Thus the fixes are needed in the main meta.import.matlab scope.

[dklilley]

Thank you for noticing this and making this change!

Can you add a test which verifies your change?

[watermarkhu]

Do you reckon this is a test that belong in the snap directory?

[dklilley]

I think it would make more sense to be a standalone test under the test/ directory. I believe the snapshot tests are meant to capture much more broad tokenization, rather than specific behaviors, to prevent a change from breaking some core functionality.

Instead, I think it would be better to create a focused test which covers the cases from your above regex101 screenshots.

I believe the number preceding the test (i.e. t##TestPoint) should correspond to the issue being fixed. If there is no issue for this bug, you can use the number of this pull request (51).

[nothans]

Thanks for the contribution. Can you contact me to get a CLA signed? Thank you!

[nothans]

The CLA has been signed. Feel free to evaluate the PR and determine if you are going to merge. Thanks!

[dklilley]

Thank you for making this fix @watermarkhu!