Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

test(floating-label): Add Jasmine component unit test #5437

Merged
merged 2 commits into from
Jan 8, 2020
Merged

test(floating-label): Add Jasmine component unit test #5437

merged 2 commits into from
Jan 8, 2020

Conversation

@allan-chen
Copy link
Collaborator

@allan-chen allan-chen commented Jan 8, 2020

Project import generated by Copybara.
@material-web-copybara @allan-chen
Project import generated by Copybara.
9b8ac07 
PiperOrigin-RevId: 288776706
@allan-chen allan-chen changed the title Project import generated by Copybara. test(floating-label): Add Jasmine component unit test Jan 8, 2020
@mdc-web-bot
Copy link
Collaborator

mdc-web-bot commented Jan 8, 2020

All 584 screenshot tests passed for commit 9b8ac07 vs. master! 💯🎉
@mdc-web-bot
Copy link
Collaborator

mdc-web-bot commented Jan 8, 2020

All 584 screenshot tests passed for commit 5d209d0 vs. master! 💯🎉
@codecov-io
Copy link

codecov-io commented Jan 8, 2020 •
edited
Loading

Codecov Report

Merging #5437 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #5437 +/- ## ========================================== - Coverage 97.84% 97.76% -0.08%  ========================================== Files 164 164 Lines 6261 6261 Branches 827 827 ========================================== - Hits 6126 6121 -5  - Misses 135 140 +5
Impacted Files Coverage Δ
packages/mdc-notched-outline/component.ts 60.71% <0%> (-17.86%) ⬇️
packages/mdc-switch/component.ts 91.52% <0%> (-6.78%) ⬇️
packages/mdc-auto-init/index.ts 92% <0%> (-4%) ⬇️
packages/mdc-floating-label/component.ts 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615f86f...5d209d0. Read the comment docs.
abhiomkar
abhiomkar approved these changes Jan 8, 2020
View reviewed changes
packages/mdc-floating-label/test/component.test.ts
@@ -22,60 +22,70 @@
*/


import {MDCNotchedOutline} from '../../mdc-notched-outline/index';
Copy link
Collaborator

@abhiomkar abhiomkar Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it this git copy automatically created by Copybara? 🤔
Copy link
Collaborator Author

@allan-chen allan-chen Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yes, this is strange
Copy link
Collaborator

@abhiomkar abhiomkar Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR accidentally replaced the notchedoutline test file. Can we restore it?
Copy link
Collaborator Author

@allan-chen allan-chen Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, must've missed a sync - opened #5449
@allan-chen allan-chen merged commit 1eb0326 into master Jan 8, 2020
@allan-chen allan-chen deleted the cl_288776706 branch January 8, 2020 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

7 participants

@allan-chen @mdc-web-bot @codecov-io @abhiomkar @googlebot @material-web-copybara