Check parameters for rand and randn #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hekaisheng added type: bug 
qinxuye approved these changes Jan 4, 2019
Collaborator
qinxuye left a comment
qinxuye left a comment There was a problem hiding this comment.
LGTM except the comments
added 2 commits January 4, 2019 17:28
qinxuye approved these changes Jan 4, 2019
Collaborator
qinxuye left a comment
qinxuye left a comment There was a problem hiding this comment.
LGTM except the comments
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Jan 7, 2019
* fix rand&rand parameters * remove kw parameter in random functions * refine in random_integers (cherry picked from commit 30902ce)
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Jan 7, 2019
* fix rand&rand parameters * remove kw parameter in random functions * refine in random_integers (cherry picked from commit 30902ce)
qinxuye pushed a commit that referenced this pull request Jan 7, 2019
wjsi added backported already ChengjieLi28 pushed a commit to ChengjieLi28/mars that referenced this pull request Jan 4, 2023
fyrestone pushed a commit to fyrestone/mars that referenced this pull request Feb 21, 2023
fyrestone added a commit that referenced this pull request Mar 14, 2023
* Implements ColumnPruning optimization rule (#30) Co-authored-by: ChengjieLi <chengjieli23@outlook.com> Co-authored-by: aresnow <aresnow1@gmail.com> * Fix execution hang on optimization error (#33) * enh: Optimize groupby nunique implementation (#38) * enh: Support passing mars objects when call df.map_chunk (#41) * enh: Support `read_parquet` for GPU (#45) * enh: Merge small data on shuffle mapper side (#49) * Fix: `series.drop_duplicates()` failed (#53) * Fix: dataframe.isna on scaler args (#55) * enh: Support df or series type for apply function (#56) * enh: Support running TPC-H queries on GPU (#60) * Avoid creating too much thread pools (#62) * enh: Optimize DataFrame.isin (#67) * tst: Fix gpu CI (#42) * enh: Refactor `read_buffers` & `write_buffers` for GPU (#68) * Fix: ensure dataframe.all acts identical to pandas (#79) * fix: Fix wrong results of `DataFrame.replace` (#86) * enh: Add `skip_infer` paramter for all use defined functions (#76) * fix: Modify signature of `df.map_chunk` (#87) * BUG: DataFrame.agg with built-in functions (#91) Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com> * Fix dataframe.ewm (#97) * BUG: Fix dataframe.sample() (#99) * BUG: df.apply with list input returns wrong answer when axis=1 (#100) * BUG: Fix md.unique (#102) * Fix implement ordered in md.cut (#104) Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com> * Fix: map_chunk output type inference (#111) * Enh: support groupby plot (#113) * ENH: Clear default context after execution (#115) * BUG: fix supervisor start method (#116) * BUG: Fix `date_range` and pin sphinx<6.0.0 (#118) * BUG: handle missing merge key (#124) * BUG: Fix `read_csv` with specific names and header (#130) * BUG: needed cols being pruned (#134) * BUG: Fix `read_parquet` with latest pyarrow (#135) * BUG: Suppress `FutureWarning` (#108) * Fix merge * Add `_repr_mimebundle_` ... as `_repr_svg_` is deprecated in `Source` class of `graphviz`. --------- Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com> Co-authored-by: ChengjieLi <chengjieli23@outlook.com> Co-authored-by: aresnow <aresnow1@gmail.com> Co-authored-by: Chengjie Li <109656400+ChengjieLi28@users.noreply.github.com> Co-authored-by: aresnow1 <109642806+aresnow1@users.noreply.github.com> Co-authored-by: qianduoduo0904 <109654808+qianduoduo0904@users.noreply.github.com> Co-authored-by: 黄浩杰 <65081722+hoarjour@users.noreply.github.com> Co-authored-by: 刘宝 <po.lb@antgroup.com> Co-authored-by: Wenjun Si <swj0066@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Check
mt.random.randandmt.random.randnparameters and raisesValueErrorif argument key not starts with '_' exceptchunk_size.Related issue number
fixes #91