Skip to content

Conversation

@Madeorsk
Copy link
Contributor

Problem

EditInDialogButton examples incorrectly specify a record in the SimpleForm.

Solution

Remove the record prop in these examples as it is only intended in a CreateInDialogButton.

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • [ ] The PR includes unit tests (if not possible, describe why)
  • [ ] The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date
@Madeorsk Madeorsk added the RFR Ready For Review label Sep 17, 2025
@Madeorsk Madeorsk changed the title Fix incorrect documentation for EditInDialogButton Fix incorrect documentation of EditInDialogButton Sep 17, 2025
@Madeorsk Madeorsk force-pushed the fix-edit-in-dialog-docs branch from b07941b to e7a94b9 Compare September 17, 2025 09:01
@Madeorsk Madeorsk added WIP Work In Progress and removed RFR Ready For Review labels Sep 17, 2025
@Madeorsk Madeorsk added WIP Work In Progress and removed RFR Ready For Review labels Sep 19, 2025
@fzaninotto fzaninotto added the RFR Ready For Review label Nov 4, 2025
@djhi djhi removed the WIP Work In Progress label Nov 5, 2025
@djhi djhi self-requested a review November 5, 2025 08:16
@djhi djhi added this to the 5.12.4 milestone Nov 5, 2025
@djhi djhi merged commit 21dab85 into master Nov 5, 2025
8 of 10 checks passed
@djhi djhi deleted the fix-edit-in-dialog-docs branch November 5, 2025 08:35
@slax57 slax57 modified the milestones: 5.12.4, 5.13.0 Nov 6, 2025
@slax57 slax57 changed the title Fix incorrect documentation of EditInDialogButton [Doc] Fix incorrect documentation of EditInDialogButton Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

5 participants