Fix compatibility with MFTF 3.10.0 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @markshust, mind checking this? Thanks :) |
| @sprankhub thanks for this! (and for reminding me... I've been quite absent-minded on GitHub lately). Merging in, will tag & release 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
MFTF 3.10.0 changed the behaviour of
\Magento\FunctionalTestingFramework\Module\MagentoWebDriver::magentoCLI: When no output is returned in the CLI, the method now returns the string "CLI did not return output.". This was introduced in magento/magento2-functional-testing-framework@fe04f75. However, a non-empty string is obviouslytruewhen casted to abool, so that we currently return a wrong result from\MarkShust\DisableTwoFactorAuth\Test\Mftf\Helper\FillOtpOverride::checkIfTwoFactorIsEnabled. This breaks the MFTF backend login and my PR fixes this.