Skip to content

Conversation

markolech
Copy link

@markolech markolech commented Jul 6, 2025

Add file icons for Markdoc files

Closes markdoc/markdoc#558

This PR adds visual file icons for Markdoc files in VSCode's file explorer to improve developer experience and file identification.

Changes

  • Add official Markdoc logo icons for light and dark themes
  • Configure file icons for .mdoc, .markdoc, and .markdoc.md extensions
  • Update .vscodeignore to include icons in extension package

Implementation

  • Uses the official Markdoc logo from https://markdoc.dev/logo.svg
  • Follows VSCode's language icon API standards
  • Icons appear in file explorer, tabs, and file dialogs

Testing

  • ✅ Extension builds successfully
  • ✅ Icons display correctly in both light and dark themes
  • ✅ All Markdoc file extensions supported
Copy link

cla-assistant bot commented Jul 6, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to use the square version (seen in the favicon on our website) instead of the rectangle one, for file icons.

Copy link
Author

@markolech markolech Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya that would probably look better. Do you have an SVG version of that icon? I can update the PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfix-stripe following up, do you have an SVG link I can use?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants