Skip to content

Commit bfad522

Browse files
author
Mark
committed
A little optimization
1 parent 6baba94 commit bfad522

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/radios.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,15 @@ class Radios extends FormElementGroup {
5353
_onFormElementClick (formElement, UIElement) {
5454
// radio buttons should only trigger a change if the clicked item isnt already selected
5555
if (this._lastRadioClicked !== formElement) {
56-
this.triggerAll(function (formElement, UIElement) {
57-
UIElement.classList.remove(this.options.selectedClass);
58-
formElement.checked = false;
56+
this.triggerAll(function (formEl, UIEl) {
57+
if (formEl !== formElement) {
58+
UIEl.classList.remove(this.options.selectedClass);
59+
formEl.checked = false;
60+
} else {
61+
UIEl.classList.add(this.options.selectedClass);
62+
formEl.checked = true;
63+
}
5964
}.bind(this));
60-
formElement.checked = true;
61-
UIElement.classList.add(this.options.selectedClass);
6265
this.triggerChange(formElement, UIElement);
6366
this._lastRadioClicked = formElement;
6467
}

0 commit comments

Comments
 (0)