optimized pick() to eliminate intermediate array allocation #636
+5 −2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Optimized the
pick()function to improve performance by eliminating intermediate array allocations. The original implementation usedkeys.map()to create an array of[key, value]tuples, then converted it to an object viaObject.fromEntries(). This created temporary data structures on every invocation.The new implementation directly constructs the result object in a single loop, reducing memory allocations and iteration overhead. Since
pick()is called twice per API request (for query params and body params), this optimization should improve performance across SDK operations.How was this change tested?
Test Results:
PASS test/id-extraction.test.ts
PASS test/helpers.test.ts
PASS test/Client.test.ts
Test Suites: 3 passed, 3 total
Tests: 24 passed, 24 total
Screenshots