[v5] Add missing page icon types and other misc fixes

examples/generate-random-data/tsconfig.json

@@ -0,0 +1,18 @@
+{
+ "compilerOptions": {
+ "target": "ES2022",
+ "module": "ES2022",
+ "moduleResolution": "Node",
+ "allowSyntheticDefaultImports": true,
+ "strict": false,
+ "esModuleInterop": true,
+ "allowJs": true,
+ "checkJs": false,
+ "resolveJsonModule": true,
+ "forceConsistentCasingInFileNames": true
+ },
+ "include": ["**/*.ts", "**/*.js"],
+ "ts-node": {
+ "esm": true
+ }
+}

src/api-endpoints.ts

@@ -6366,7 +6366,11 @@ type FileUploadWithOptionalNameRequest = {
  name?: StringRequest
 }
 
-type PageIconRequest = FileUploadPageIconRequest | EmojiPageIconRequest
+type PageIconRequest =
+ | FileUploadPageIconRequest
+ | EmojiPageIconRequest
+ | ExternalPageIconRequest
+ | CustomEmojiPageIconRequest
 
 type PageCoverRequest = FileUploadPageCoverRequest | ExternalPageCoverRequest
 
@@ -7454,6 +7458,26 @@ type EmojiPageIconRequest = {
  emoji: EmojiRequest
 }
 
+type ExternalPageIconRequest = {
+ type?: "external"
+ external: {
+ // The URL of the external file.
+ url: string
+ }
+}
+
+type CustomEmojiPageIconRequest = {
+ type?: "custom_emoji"
+ custom_emoji: {
+ // The ID of the custom emoji.
+ id: IdRequest
+ // The name of the custom emoji.
+ name?: string
+ // The URL of the custom emoji.
+ url?: string
+ }
+}
+
 type FileUploadPageCoverRequest = {
  type?: "file_upload"
  // The file upload for the cover.

src/errors.ts

@@ -119,6 +119,8 @@ export class RequestTimeoutError extends NotionClientErrorBase<ClientErrorCode.R
 
 type HTTPResponseErrorCode = ClientErrorCode.ResponseError | APIErrorCode
 
+type AdditionalData = Record<string, string | string[]>
+
 class HTTPResponseError<
  Code extends HTTPResponseErrorCode
 > extends NotionClientErrorBase<Code> {
@@ -127,20 +129,23 @@ class HTTPResponseError<
  readonly status: number
  readonly headers: SupportedResponse["headers"]
  readonly body: string
+ readonly additional_data: AdditionalData | undefined
 
  constructor(args: {
  code: Code
  status: number
  message: string
  headers: SupportedResponse["headers"]
  rawBodyText: string
+ additional_data: AdditionalData | undefined
  }) {
  super(args.message)
- const { code, status, headers, rawBodyText } = args
+ const { code, status, headers, rawBodyText, additional_data } = args
  this.code = code
  this.status = status
  this.headers = headers
  this.body = rawBodyText
+ this.additional_data = additional_data
  }
 }
 
@@ -193,6 +198,7 @@ export class UnknownHTTPResponseError extends HTTPResponseError<ClientErrorCode.
  message:
  args.message ??
  `Request to Notion API failed with status: ${args.status}`,
+ additional_data: undefined,
  })
  }
 
@@ -243,6 +249,7 @@ export function buildRequestError(
  headers: response.headers,
  status: response.status,
  rawBodyText: bodyText,
+ additional_data: apiErrorResponseBody.additional_data,
  })
  }
  return new UnknownHTTPResponseError({
@@ -253,9 +260,13 @@ export function buildRequestError(
  })
 }
 
-function parseAPIErrorResponseBody(
- body: string
-): { code: APIErrorCode; message: string } | undefined {
+function parseAPIErrorResponseBody(body: string):
+ | {
+ code: APIErrorCode
+ message: string
+ additional_data: AdditionalData | undefined
+ }
+ | undefined {
  if (typeof body !== "string") {
  return
  }
@@ -279,6 +290,7 @@ function parseAPIErrorResponseBody(
  ...parsed,
  code: parsed["code"],
  message: parsed["message"],
+ additional_data: parsed["additional_data"] as AdditionalData | undefined,
  }
 }
 

test/Client.test.ts

@@ -1,5 +1,5 @@
 import assert = require("assert")
-import { Client } from "../src"
+import { APIResponseError, Client } from "../src"
 
 describe("Notion SDK Client", () => {
  it("Constructs without throwing", () => {
@@ -136,5 +136,49 @@ describe("Notion SDK Client", () => {
  })
  )
  })
+
+ it("parses additional_data from API validation error response", async () => {
+ mockFetch.mockResolvedValue({
+ ok: false,
+ text: () =>
+ Promise.resolve(
+ JSON.stringify({
+ code: "validation_error",
+ message:
+ "Databases with multiple data sources are not supported in this API version.",
+ object: "error",
+ status: 400,
+ additional_data: {
+ error_type: "multiple_data_sources_for_database",
+ database_id: "123",
+ child_data_source_ids: ["456", "789"],
+ minimum_api_version: "2025-09-03",
+ },
+ })
+ ),
+ headers: new Headers(),
+ status: 400,
+ } as Response)
+
+ try {
+ await notion.databases.retrieve({
+ database_id: "123",
+ })
+ assert.fail("Expected error to be thrown")
+ } catch (error) {
+ assert(error instanceof APIResponseError)
+ expect(error.code).toEqual("validation_error")
+ expect(error.status).toEqual(400)
+ expect(error.message).toEqual(
+ "Databases with multiple data sources are not supported in this API version."
+ )
+ expect(error.additional_data).toEqual({
+ error_type: "multiple_data_sources_for_database",
+ database_id: "123",
+ child_data_source_ids: ["456", "789"],
+ minimum_api_version: "2025-09-03",
+ })
+ }
+ })
  })
 })