- Notifications
You must be signed in to change notification settings - Fork 4
[Snyk] Upgrade playground-elements from 0.20.0 to 0.21.0 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade playground-elements from 0.20.0 to 0.21.0. See this package in npm: playground-elements See this project in Snyk: https://app.snyk.io/org/maicol07/project/7bc120c4-da8d-47a8-b76c-4553af1c8acb?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @maicol07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades playground-elements from 0.20.0 to 0.21.0. This is a valuable update as it fixes some bugs, but it also comes with a risk. The new version includes a major upgrade of its dependency CodeMirror to v6, which is marked as a potentially breaking change. This could affect the interactive playground examples used in the catalog. I have added a comment to package.json detailing this risk. It's important to ensure no regressions are introduced before merging.
| "@preact/signals-core": "^1.8.0", | ||
| "lit": "^3.3.0", | ||
| "playground-elements": "^0.20.0", | ||
| "playground-elements": "^0.21.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to playground-elements v0.21.0 introduces a significant risk of regressions. While the update fixes cursor issues in Safari, it does so by upgrading its dependency CodeMirror to v6. The release notes explicitly flag this as a POTENTIALLY BREAKING change. Given the project's use of <playground-file-editor>, this could result in new visual or functional problems in the interactive demos. Any such regressions will need to be addressed before this change is merged.
Snyk has created this PR to upgrade playground-elements from 0.20.0 to 0.21.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 24 days ago.
Release notes
Package name: playground-elements
- 0.21.0 - 2025-09-23
- POTENTIALLY BREAKING Upgraded CodeMirror to v6
- Added
- Added an
- Exported
- Safari cursor issues
- Cursor selection and visiblity was broken in Safari
- Fixed by updating to Codemirror 6
- 0.20.0 - 2025-04-01
- Implement
- Make playground-elements more resilient to 404's from the CDN by not throwing errors when they occur. Instead, log a warning and continue to load the rest of the project.
from playground-elements GitHub release notesChanged
Added
extensionsproperty to<playground-ide>,<playground-file-editor>, and<playground-code-editor>for applyingprogrammatic CodeMirror extensions.
extensionsslot to<playground-ide>,<playground-file-editor>, and<playground-code-editor>for applyingdeclarative CodeMirror extensions.
codemirrorExtensionMixinfor creating declarative CodeMirrorextensions.
Fixed
Added
cdnBaseUrlproperty to allow changing the underlying npm CDN base url. See README for more information.Fixed
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: