system_file.xsd - better code highlight when using URN schemas

[jakwinkler]

Description (*)

Fixes XML schema definitions in phpstorm, from this:

to this:

Related Pull Requests

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @jakwinkler. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[jakwinkler]

@magento run all tests

[jakwinkler]

@magento run all tests

[jakwinkler]

@magento run all tests

[hostep]

Thanks @jakwinkler, but it looks like we already have a PR that tries to fix the same thing over here: #39675

[engcom-Hotel]

Thanks @hostep for highlighting the other PR which fixes the same issues.

@jakwinkler please have a look at the other PR, till the time moving this PR on hold.

[jakwinkler]

@hostep that was my initial idea as well, but some comments use a model to generate a comment and your solution won't work if you have some Adobe Commerce module installed.
Check my commit history and you'll see that I've tried to use same approach but it will fail on this code

<comment model="Magento\Securitytxt\Model\Config\Signature"/> 

My PR covers all scenarios :-)

[hostep]

Nice! Good to hear you did some research. Then I agree we should proceed with this PR and close the other one.

[engcom-Dash]

Raised internal approval JIRA for the SVC failure.

SVC : https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39867/ef21e4b107a5b1e9a68cff7e946df2f5/SemanticVersionChecker/report-magento2.html

@engcom-Hotel we have closed other PR #39675 (comment) as this one covers all the possible scenarios. Moving this PR for review.

Thanks!

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @jakwinkler,

Thank you for contribution & collaboration!

✔️ QA Passed

Preconditions:

1. install fresh Magento 2.4-develop
2. Install PhpStrom.

Steps to reproduce:
As per the PR & issue description

Before : ❌

After : ✔️

As mentioned in #39867 (comment) we have raised internal JIRA for the SVC failure hence moving this PR in "Penfing Approval". Once we get all the required approvals we will proceed with the PR.

[jakwinkler]

@magento run all tests

[jakwinkler]

https://github.com/magento run all tests

[engcom-Dash]

We have received the approval on the JIRA hence moving this PR to Extended testing to proceed further on this PR.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests EE, Static Tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B

[engcom-Dash]

For the SVC failure we have got required approvals JIRA.

Apart from SVC failure, no other builds are failing hence moving this PR in Merge In Progress.