Skip to content

Conversation

ckd
Copy link
Contributor

@ckd ckd commented Oct 28, 2024

Description (*)

Minor copyedit to correct spelling of "copying"

Related Pull Requests

n/a

Fixed Issues (if relevant)

n/a

Manual testing scenarios (*)

n/a

Questions or comments

n/a

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Copyedit: change "coping" to "copying" #39311: Copyedit: change "coping" to "copying"
Copy link

m2-assistant bot commented Oct 28, 2024

Hi @ckd. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Oct 29, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Feb 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ckd,

Thanks for the contribution!

The changes seem good to us but please fix the static test failures.

Also I want to suggest to fix a typo in the below line as well (startegt to strategy):

* Validation startegt field name

@ckd
Copy link
Contributor Author

ckd commented Feb 18, 2025

Hi @engcom-Hotel! Added the additional typo correction to the PR, but the static test failures seem to be upstream and unrelated to this change

@engcom-Hotel
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ckd, for making the changes.

But we are still having static test failures. Please fix those.

@ckd
Copy link
Contributor Author

ckd commented Feb 19, 2025

@engcom-Hotel those failures are out of scope for this PR, they need to be fixed upstream

@engcom-Hotel
Copy link
Contributor

Hello @ckd, we can see the copywrite failures on the files in this PR. You just need to make the changes in the file as follows:

Copyright [year code created] Adobe All Rights Reserved. 
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Unit Tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ckd,

Thanks for fixing the issues!

But we are still having some static test failures. Please fix those and then run all tests to verify.

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @ckd,

We are picking this PR for further processing.

Thanks

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Static Tests

@engcom-Hotel engcom-Hotel moved this from Changes Requested to Review in Progress in Community Dashboard Feb 27, 2025
@engcom-Hotel engcom-Hotel moved this from Review in Progress to Ready for Testing in Community Dashboard Feb 27, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Feb 28, 2025
@engcom-Bravo
Copy link
Contributor

Hi @ckd,

Thanks for the collaboration & contribution!

✔️ QA Passed

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Feb 28, 2025
@engcom-Dash engcom-Dash self-assigned this Mar 4, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Mar 5, 2025

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Mar 5, 2025
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 7226b92 into magento:2.4-develop Apr 2, 2025
10 of 12 checks passed
@engcom-Charlie engcom-Charlie moved this from Merge in Progress to Recently Merged in Community Dashboard Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community
7 participants