Skip to content

Task/38939 docblock change #39001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 7, 2025
Merged

Task/38939 docblock change #39001

merged 7 commits into from
Jan 7, 2025

Conversation

Mohamed-Asar
Copy link
Contributor

@Mohamed-Asar Mohamed-Asar commented Aug 2, 2024 •
edited
Loading

Description (*)

Doc block change -> \Magento\ProductAlert\Model\Stock::deleteCustomer

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 2, 2024

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.
@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Aug 2, 2024
@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Aug 2, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Dec 11, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 11, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests
@engcom-Hotel
Copy link
Contributor

@magento run Static Tests
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE, Unit Tests
engcom-Hotel
engcom-Hotel requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mohamed-Asar,

Thanks for the contribution!

Please address the failed tests, particularly the static tests. Other tests seems flaky to me.

Thanks
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests
@Mohamed-Asar
Copy link
Contributor Author

Hello @engcom-Hotel,

Static test issues are fixed. please review
@engcom-Dash engcom-Dash self-assigned this Dec 18, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests
@engcom-Dash
Copy link
Contributor

Manual testing is not required here, as this PR is only updating the doc block. Since the builds are failing, moving it to Extended Testing.
@engcom-Dash
Copy link
Contributor

@magento run all tests
@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Functional Tests EE, Functional Tests B2B
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Dec 19, 2024 •
edited
Loading

The Functional B2B and EE test failures are inconsistent in the last two builds and seem to be flaky. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39001/39f7e0d337978493cb28b0605a762071/Functional/allure-report-b2b/index.html#categories/7441e147742cc9294f4ce2a0b5090c42/bc9ba123a8c7a22a/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39001/a321f77a7aa41f73df83581ad79483ec/Functional/allure-report-b2b/index.html#categories/2fc037f47773dd7551f2e766bbf34efa/bd021f6ba00492d7/
image

Functional Tests EE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39001/724cb0f8267827a590bb263bd624c20c/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39001/04a4e3a25981ab94acb9e3764d3b1ec0/Functional/allure-report-ee/index.html#categories/089c34e15cffa054c840ca8e9a9dd97a/2d6b6b5e158f745f/
image
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit a76a86f into magento:2.4-develop Jan 7, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
7 participants
@Mohamed-Asar @engcom-Hotel @engcom-Dash @engcom-Bravo @magento-devops-reposync-svc @m2-github-services @Priyakshic