Skip to content

Conversation

jlnarvaez
Copy link
Contributor

@jlnarvaez jlnarvaez commented Jul 17, 2024

Description (*)

This PR remove a unknown referenced variable in PHPDoc for $helper variable declaration.

Manual testing scenarios (*)

This fix has no testing scenario, because is a code typo.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix typo in PHPDoc block #38961: Fix typo in PHPDoc block
Copy link

m2-assistant bot commented Jul 17, 2024

Hi @jlnarvaez. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@jlnarvaez
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 23, 2024
5 tasks
@engcom-Charlie engcom-Charlie added the Priority: P3 May be fixed according to the position in the backlog. label Jul 23, 2024
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@engcom-Dash
Copy link
Contributor

QA is not required for this change since it only updates the property annotation for $helper.

Builds are failing so moving it to extended testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Integration Tests, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

We have seen static failures in mainline PR after merging this PR into that. Hence for now moving this PR to Extended testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Nov 26, 2024

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 7832162 into magento:2.4-develop Dec 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: ConfigurableProduct Priority: P3 May be fixed according to the position in the backlog. Progress: accept Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
7 participants