- Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix a few typos in PHPDoc comments #38809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few typos in PHPDoc comments #38809
Conversation
Hi @artttj. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run all tests |
@magento run all tests |
1 similar comment
@magento run all tests |
8d5c046
to d6deb46
Compare @magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @artttj,
Thanks for the contribution!
As I can see in this PR, you have tried to fix some typos but we have some static test failures. We request you to fix those.
Other failures seems flaky to me.
Thanks
Hello @artttj I wanted to check if you are working on the static failures. If not, Can I take care of them? Just let me know what works best for you. |
Hello @artttj I am taking care of the changes. Thank You! |
@magento run all tests |
Thanks for resolving, I appreciate it! |
Hi @artttj, Thanks for the collaboration & contribution! ✔️ QA PassedBuilds are failed. Hence, moving this PR to Extended Testing. Thanks. |
@magento create issue |
@magento run all tests |
1 similar comment
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests |
The consistent Functional B2B Tests failure is known issue and Jira has been raised for the same. Other failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes. Known Issue: StorefrontProductNoLongerVisibleInWishlistOnceUserUnassignedFromCompanyTest ACQE-8287 The Functional EE failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes. Hence moving this PR in Merge In Progress. |
@magento run all tests |
1 similar comment
@magento run all tests |
Hi @artttj , Thank you for your contribution! I just wanted to let you know that your pull request is now in the merge in progress stage. From this point onward, our team will take care of the remaining steps. No further action is required from your end. Thanks! |
af8b297
into magento:2.4-develop
Description (*)
Fix a few typos in PHPDoc comments:
Manual testing scenarios (*)
N/A
Contribution checklist (*)
Resolved issues: