avoid a misconfiguration infinite loop

[ergohack]

Description (*)

The virtual type configurations, in di.xml files, are not supposed to be self‑referential, … but if they ever are this function will spin in an infinite loop.

Changes

Added a test to avoid a self‑referential mapping, returning the self‑reference instead of endlessly spinning.

Fixed Issues (if relevant)

unknown

Manual testing scenarios (*)

Configure a di.xml <virtualType …> node to be self‑referential (i.e. not actually virtual). This will cause the app to spin, infinitely, on the dereferencing attempt. Note that the self‑reference can be from a chain of <virtualType …> nodes and not just a single node.

Contribution checklist (*)

• [√] Pull request has a meaningful description of its purpose
• [√] All commits are accompanied by meaningful commit messages
• [n/a] All new or changed code is covered with unit/integration tests (if applicable)
• [n/a] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [unknown] All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] avoid a misconfiguration infinite loop #38822: avoid a misconfiguration infinite loop

[m2-assistant]

Hi @ergohack. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests

[engcom-Charlie]

@magento create issue

[engcom-November]

@magento run all tests

[engcom-November]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

[engcom-November]

@magento run Unit Tests

[engcom-November]

@magento run Unit Tests

[engcom-November]

@magento run all Tests

[engcom-November]

@magento run all tests

[engcom-November]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-November]

The repeating Functional Tests EE failure is falky and known issue.

Functional Tests EE:
Run 1:

Run 2:

Known issue:
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

Hence moving this to Merge in progress

[engcom-Dash]

Moving it back to ET to analyze the build result, as the build URL was not attached in the #38794 (comment) about flaky tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Unit Tests

[engcom-Dash]

We got a green build, so I’m moving this to "Merge in Progress."