Skip to content

Conversation

Nuranto
Copy link
Contributor

@Nuranto Nuranto commented Apr 25, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Graphql] Type issue in 2.4.7 #38662

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
Copy link

m2-assistant bot commented Apr 25, 2024

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Nuranto
Copy link
Contributor Author

Nuranto commented Apr 25, 2024

@magento run all tests

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 11, 2024
@engcom-Delta engcom-Delta added the Project: Community Picked PRs upvoted by the community label Aug 16, 2024
@engcom-Hotel
Copy link
Contributor

@magento run WebAPI Tests, Static Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 21, 2024
@engcom-Charlie engcom-Charlie self-assigned this Aug 21, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

Hi @Nuranto,

Thank you for your contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  1. Created customer custom attribute with type as int
'custom', [ 'label' => 'custom', 'input' => 'select', 'type' => 'int', 'source' => 'Magento\Eav\Model\Entity\Attribute\Source\Boolean', 'required' => true, 'default' => '1', 'position' => 333, 'visible' => true, 'system' => false, 'is_used_in_grid' => true, 'is_visible_in_grid' => true, 'is_filterable_in_grid' => true, 'is_searchable_in_grid' => false, 'backend' => '' ] 
  1. Set developer mode in the magento instance
  2. Create one customer and logged in with that user in storefront
  3. Execute below GraphQl query
query AccountDashboard { __typename customer { email __typename } } 

Before: ✖️ 
image

After: ✔️ on PR branch
image

Build is failing hence moving this PR to Extended Testing.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Charlie
Copy link
Contributor

Some of the Functional EE failures are not consistent in recent 2 builds, seems to be flaky and not related to PR. One test failure is consistent and its a known failure and have open issue for the same. Hence moving this PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38663/a22056aa7891bc00858d300a3a618145/Functional/allure-report-ee/index.html#categories/f5a70ec99dae2c5e7b2f1aa499dc4363/5a67b3984193b59f/

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38663/df567d24129aa262ab672da5a413161b/Functional/allure-report-ee/index.html#categories

image

Known issue :

  • StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 1dd4bb9 into magento:2.4-develop Sep 5, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
6 participants