Display backordered quantity if the order item has them #38320

dverkade · 2023-12-27T09:24:24Z

Description

This PR will show the number of items that are backordered for every order item in the order overview screen.

Fixed Issues

Fixes Backend order overview screen: Backordered quantity not visible on order item level #38252

Manual testing scenarios

Have a product which allows backorders.
Create an order with a product that allows backorders and make sure there's no current inventory for that item.
Order overview will show the quantity of the product that are in backorder.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2023-12-27T09:24:27Z

Hi @dverkade. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

dverkade · 2023-12-27T09:24:38Z

@magento run all tests

magento-automated-testing · 2023-12-27T09:24:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

rogyar

Hi @dverkade. Thanks a lot for your contribution. Please, check the failing static and functional tests. As for the functional tests - there's a classical issue where assertion is made on some child element. Once you've introduced a new child, the tests are failing. So, it's a matter of a simple test adjustment.

Thanks.

dverkade · 2024-01-24T14:18:21Z

@rogyar I've changed the template to pass the static tests. Regarding the functional test failing, that's not an issue of this commit as the commit is for the Sales module and displaying the backordered quantity on the order overview page. The failing functional test is for: "on page /admin/catalog/product/index" which is a false positive.

Den4ik

@dverkade Thanks for contribution.
Please look at my comment

Den4ik · 2024-05-25T19:45:37Z

app/code/Magento/Sales/view/adminhtml/templates/items/column/qty.phtml

+ <th><?= $block->escapeHtml(__('Backordered')); ?></th>
+ <td><?= (float) $item->getQtyBackordered() ?></td>


Using escape functions from the Template class was deprecated. Please use $escaper.
It would be good replace all calls in this file.

engcom-Charlie · 2024-05-27T09:00:58Z

@magento run all tests

engcom-Charlie · 2024-05-27T11:39:31Z

@magento run all tests

engcom-Charlie · 2024-05-27T13:27:16Z

@Den4ik I have updated the code as requested in comment. Requesting for the review.

engcom-Hotel · 2024-05-31T06:43:16Z

@magento run all tests

engcom-Hotel · 2024-05-31T08:59:35Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

engcom-Hotel

Failed tests seem flaky to me, hence approving the PR.

Den4ik

Now looks good for me.
@engcom-Charlie Thanks for update

engcom-Bravo · 2024-06-03T06:44:37Z

@magento run all tests

engcom-Bravo · 2024-06-03T09:37:53Z

Hi @dverkade,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Have a product which allows backorders.
Create an order with a product that allows backorders and make sure there's no current inventory for that item.
Order overview will show the quantity of the product that are in backorder.

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Charlie · 2024-06-04T06:08:57Z

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

engcom-Charlie · 2024-06-04T10:21:05Z

The Functional B2B, EE, WebAPI tets failures seems to be flaky and having known issues in it. Hence moving this PR to Merge in Progress.

WebAPI Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38320/6693de30abf00cfa6ba6a93ca5b85925/WebApi/console-error-logs.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38320/7295c536f85ba01de73294e474a74599/WebApi/console-error-logs.html

Known Issues:
testSendNegotiableQuoteCannotResend: #ACP2E-3082

Functional B2B Run1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38320/48cb80f610e8053ca7b9755464763a5b/Functional/allure-report-b2b/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38320/98c0e44ef5a3b8a97e14b05077128232/Functional/allure-report-b2b/index.html#categories

Known Issues:
AdminReorderWithCatalogPriceRuleDiscountTest: ACQE-6523
StorefrontUpdateCustomerAddressBelgiumTest: ACQE-6648

Functional EE Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38320/22ec2fa6c97d8ce03fb372c477c87b0c/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38320/7f17651c7487cce2ff05e5ab10a7c239/Functional/allure-report-ee/index.html#categories

Known Issues:
AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest: ACQE-6590
StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest : ACQE-6331
AdminReorderWithCatalogPriceRuleDiscountTest: ACQE-6523

Display backordered quantity if the order item has them

0e664a0

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 27, 2023

m2-community-project bot added the Progress: pending review label Dec 27, 2023

rogyar self-assigned this Jan 17, 2024

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 17, 2024

rogyar suggested changes Jan 17, 2024

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 17, 2024

Changed template according to Magento coding standards.

d06342d

sinhaparul added the Project: Community Picked PRs upvoted by the community label May 21, 2024

m2-community-project bot added Progress: pending review and removed Progress: needs update labels May 23, 2024

Merge branch '2.4-develop' into 2.4-develop

21066b9

Den4ik requested changes May 25, 2024

View reviewed changes

m2-community-project bot assigned Den4ik May 25, 2024

m2-community-project bot added Progress: needs update and removed Progress: pending review labels May 25, 2024

engcom-Charlie self-assigned this May 27, 2024

Used escaper to resolve review comment

63f8ae6

m2-community-project bot added Progress: pending review and removed Progress: needs update labels May 27, 2024

engcom-Hotel self-requested a review May 31, 2024 05:48

m2-community-project bot added Progress: review and removed Progress: pending review labels May 31, 2024

Merge branch '2.4-develop' into 2.4-develop

ea947c4

engcom-Hotel approved these changes May 31, 2024

View reviewed changes

m2-community-project bot assigned engcom-Hotel May 31, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: review labels May 31, 2024

Den4ik approved these changes May 31, 2024

View reviewed changes

engcom-Bravo self-assigned this Jun 3, 2024

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jun 3, 2024

Merge branch '2.4-develop' into 2.4-develop

a68f23a

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Jun 3, 2024

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jun 4, 2024

magento-devops-reposync-svc merged commit 52229c0 into magento:2.4-develop Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Display backordered quantity if the order item has them #38320

Display backordered quantity if the order item has them #38320

Uh oh!

dverkade commented Dec 27, 2023

m2-assistant bot commented Dec 27, 2023

dverkade commented Dec 27, 2023

magento-automated-testing bot commented Dec 27, 2023

rogyar left a comment

dverkade commented Jan 24, 2024

Den4ik left a comment

Den4ik May 25, 2024

engcom-Charlie commented May 27, 2024

engcom-Charlie commented May 27, 2024

engcom-Charlie commented May 27, 2024

engcom-Hotel commented May 31, 2024

engcom-Hotel commented May 31, 2024

engcom-Hotel left a comment

Den4ik left a comment

engcom-Bravo commented Jun 3, 2024

engcom-Bravo commented Jun 3, 2024

engcom-Charlie commented Jun 4, 2024

engcom-Charlie commented Jun 4, 2024 •

edited

Loading

		<th><?= $block->escapeHtml(__('Backordered')); ?></th>
		<td><?= (float) $item->getQtyBackordered() ?></td>

Display backordered quantity if the order item has them #38320

Display backordered quantity if the order item has them #38320

Uh oh!

Conversation

dverkade commented Dec 27, 2023

Description

Fixed Issues

Manual testing scenarios

Contribution checklist

m2-assistant bot commented Dec 27, 2023

dverkade commented Dec 27, 2023

magento-automated-testing bot commented Dec 27, 2023

rogyar left a comment

Choose a reason for hiding this comment

dverkade commented Jan 24, 2024

Den4ik left a comment

Choose a reason for hiding this comment

Den4ik May 25, 2024

Choose a reason for hiding this comment

engcom-Charlie commented May 27, 2024

engcom-Charlie commented May 27, 2024

engcom-Charlie commented May 27, 2024

engcom-Hotel commented May 31, 2024

engcom-Hotel commented May 31, 2024

engcom-Hotel left a comment

Choose a reason for hiding this comment

Den4ik left a comment

Choose a reason for hiding this comment

engcom-Bravo commented Jun 3, 2024

engcom-Bravo commented Jun 3, 2024

engcom-Charlie commented Jun 4, 2024

engcom-Charlie commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

engcom-Charlie commented Jun 4, 2024 •

edited

Loading