Duplicate cache fpc for same page with same query

[rogerdz]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Duplicate cache fpc for same page with same query #38269

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run Integration Tests, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @rogerdz,

Thanks for the contribution!

Please check the build failures, it seems they are failing due to code changes.

Thanks

[rogerdz]

@magento run all tests

[rogerdz]

@magento run all tests

[engcom-Dash]

The Functional B2B and CE test failures seem flaky and some of these failures are known issues. They are neither part of PR nor failing because of PR changes. Hence moving it to Merge in Progress.

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38270/95b9984bc468ba92a21b2e99d9e1191e/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38270/439533c23bc0fa30bcd92ba6c99a9194/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
MultiShippingWithCreationNewCustomerAndAddressesDuringCheckoutTest: ACQE-7229
StorefrontReuseCouponCodeAfterOrderCanceledTest: ACQE-7230

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38270/4a790f66b688e1fb03a7fe28cdca61a9/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/190a9b2622ef3f4/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38270/dc0707fb0b4f81610a28b9acfd370cfe/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/5ba8ed3be74fdf64/

Known Issue:
VerifyDefaultWYSIWYGToolbarOnProductTest: ACQE-7227

[engcom-Dash]

Moving back to the changes requested, as there are conflicts in the files

[engcom-Dash]

Hello @rogerdz,

Thanks for the contributions!

There are conflicts in the files. Could you please take a look and resolve them? Meanwhile, I am putting it on hold. Once the conflicts are resolved, we will proceed further.

Thanks again!

[engcom-Charlie]

Hi @rogerdz,

Did you get a chance to look into the conflicts as mentioned here. Currently, we are closing this PR, once its done please feel free to reopen.

Thank you!

[m2-assistant]

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[rogerdz]

@magento run all tests

[rogerdz]

Hi @engcom-Charlie,

I fixed conflicts.
Thank you.

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B

[engcom-Charlie]

Hi @rogerdz,

The addressed issue in this PR seems to be not exists anymore.

The issue is not reproducible after trying below steps as mentioned in description in Magento2 repository.

1. Install fresh Magento 2.4-develop
2. Install Sample data
3. Check FPC is set in magento instance
4. Enable developer mode
5. Clear the cache.
6. Sent below CURL request one after other, all gave the same result in magento 2 repository

• http://magento.local/gear/bags.html?activity=20
• http://magento.local/gear/bags.html?activity=20&style_bags=28
• http://magento.local/gear/bags.html?activity=20&performance_fabric=1&style_bags=28

All above URLs giving HIT. As, the issue is no more exits now, hence closing this PR for now. Please feel free to reopen it for any further updates.

[rogerdz]

Hi @engcom-Charlie ,
Issue still reproducible in my local

Your test is not correct, please check #38269 (comment)

[engcom-Charlie]

Hi @rogerdz,

The addressed issue in this PR seems to be not exists anymore.

The issue is not reproducible after trying below steps as mentioned in description in Magento2 repository.

1. Install fresh Magento 2.4-develop
2. Install Sample data
3. Check FPC is set in magento instance
4. Enable developer mode
5. Clear the cache.
6. Sent below CURL request one after other, all gave the same result in magento 2 repository

• http://magento.local/gear/bags.html?activity=20
• http://magento.local/gear/bags.html?activity=20&style_bags=28
• http://magento.local/gear/bags.html?activity=20&performance_fabric=1&style_bags=28

All above URLs giving HIT. As, the issue is no more exits now, hence closing this PR for now. Please feel free to reopen it for any further updates.

It seems that I have tried to reproduce the issue with PR code itself hence got this result.

The issue is reproducible on Magento2 repository and working fine on PR instance.

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop
• Install Sample data

Steps to reproduce

• Check FPC is set in magento instance
• Enable developer mode
• Clear the cache.

Before: ✖️ 
Result on below CURL requests on magento 2.4-develop

curl -I --location-trusted 'http://magento.local/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug: MISS curl -I --location-trusted 'http://magento.local/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug: HIT curl -I --location-trusted 'http://magento.local/gear/bags.html?style_bags=24&activity=8' | grep -i X-Magento-Cache-Debug: MISS curl -I --location-trusted 'http://magento.local/gear/bags.html?activity=8&style_bags=24&' | grep -i X-Magento-Cache-Debug: MISS 

After: ✔️

Result on below CURL requests on PR branch curl -I --location-trusted 'http://magento.local/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug: MISS curl -I --location-trusted 'http://magento.local/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug: HIT curl -I --location-trusted 'http://magento.local/gear/bags.html?style_bags=24&activity=8' | grep -i X-Magento-Cache-Debug: HIT curl -I --location-trusted 'http://magento.local/gear/bags.html?activity=8&style_bags=24&' | grep -i X-Magento-Cache-Debug: HIT 

The build is successful. Hence, moving this PR to Merge in Progress.

Thanks.