Skip to content

Update Ga.php to fix no revenue data in GA4 #37688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2023
Merged

Update Ga.php to fix no revenue data in GA4 #37688

merged 5 commits into from
Aug 31, 2023

Conversation

DomPixie
Copy link
Contributor

@DomPixie DomPixie commented Jun 29, 2023 •
edited by engcom-Lima
Loading

Description (*)

Fix for No revenue data in GA4

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes No revenue data in GA4 when using Magento_GoogleGtag extension #37605

Manual testing scenarios (*)

  1. Switch on Google Analytics 4 part of the Magento Google Gtag extension
  2. Place an order
  3. Wait for data to appear in Google Analytics 4
  4. On GA4, goto Reports->Monetization-> Verify the Revenue in the Monetization overview.

Correct revenue data is reported

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant
Copy link

m2-assistant bot commented Jun 29, 2023

Hi @DomPixie. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.
@DomPixie
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@DomPixie DomPixie closed this Jun 29, 2023
@DomPixie DomPixie reopened this Jun 29, 2023
@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jun 30, 2023
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Jul 26, 2023
ihor-sviziev
ihor-sviziev requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing unit tests
@DomPixie
Copy link
Contributor Author

@magento run Unit Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@DomPixie
Copy link
Contributor Author

@ihor-sviziev I believe this has been done - thanks
@engcom-Charlie engcom-Charlie self-assigned this Jul 31, 2023
@engcom-Charlie
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Charlie
Copy link
Contributor

@magento run Unit Tests, Integration Tests, WebAPI Tests, Functional Tests CE, Functional Tests B2B, Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Charlie engcom-Charlie removed their assignment Aug 1, 2023
@engcom-Echo engcom-Echo self-assigned this Aug 1, 2023
@engcom-Echo
Copy link
Contributor

@magento run Unit Tests
@engcom-Lima engcom-Lima self-assigned this Aug 2, 2023
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1
  • Account should be created on the Google of GA4.

Manual testing scenario:

  1. Switch on Google Analytics 4 part of the Magento Google Gtag extension
  2. Place an order
  3. Wait for data to appear in Google Analytics 4
  4. On GA4, go to Reports->Monetization and verify the Correct revenue data is reported

Before: ✖️

Screenshot 2023-08-07 at 12 54 35 PM

After: ✔️
Screenshot 2023-08-07 at 12 45 25 PM
Screenshot 2023-08-07 at 12 45 30 PM

Builds are failed. Hence, moving this PR to Extended Testing.
@engcom-Echo
Copy link
Contributor

Failing test are not related to PR changes.
Hence moving it to Merge in progress
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run WebAPI Tests,Unit Tests,Integration Tests,Functional Tests EE,Functional Tests CE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

Functional Tests EE and Functional Tests CE failure are different on last two run.
Functional Tests CE
Run1
37668-ce

Run2
37668-ce2

Functional Tests EE
Run1
37668-ee

Run2
37668-ee2

Other Failures are not related to PR
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 0c799d3 into magento:2.4-develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community
8 participants
@DomPixie @engcom-Charlie @engcom-Echo @engcom-Lima @ihor-sviziev @engcom-Hotel @sinhaparul @magento-devops-reposync-svc