Added: SKU with configurable, group, bundle product Title #37578

aasim110 · 2023-06-05T09:37:02Z

Description (*)

Changed Magento/Paypal/Model/Cart.php file to add child product SKUs with the Parent product title to identify the product title with the child SKU.
Check this screenshot for more information: https://prnt.sc/0VgjbwOg-omA

Related Pull Requests

Fixed Issues (if relevant)

Fixes [2.4.5-p1] PayPal Express Checkout - Missing SKU & Full product [variation] title #36808

Manual testing scenarios (*)

Enable PayPal Express Checkout [sandbox or live, the result is the same so just do sandbox for this test]
Enable "Transfer Cart Line Items"
Enable "PayPal Guest Checkout"
Submit the Order (by credit card using a test number provided HERE). It is the same end result using a PayPal personal account but for testing purposes just use a test credit card for easier testing.
Check PayPal transactions in the PayPal sandbox account (not Magento)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2023-06-05T09:37:06Z

Hi @aasim110. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

aasim110 · 2023-06-05T09:38:50Z

@magento run all tests

magento-automated-testing · 2023-06-05T09:39:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-05T13:17:54Z

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2023-06-05T13:18:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-05T16:13:55Z

@magento run Functional Tests EE

magento-automated-testing · 2023-06-05T16:14:06Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-06T16:21:35Z

@magento run Functional Tests EE

magento-automated-testing · 2023-06-06T16:21:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-06T16:22:49Z

@magento run all Tests

magento-automated-testing · 2023-06-06T16:22:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-07T04:07:05Z

@magento run Functional Tests CE

magento-automated-testing · 2023-06-07T04:07:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-07T08:48:10Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-06-07T08:48:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-07T11:34:44Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-06-07T11:34:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-07T13:37:18Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-06-07T13:37:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-08T05:12:49Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-06-08T05:12:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-08T18:02:08Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-06-08T18:02:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-09T05:12:46Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-06-09T05:12:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-06-09T14:03:06Z

@magento run all Tests

magento-automated-testing · 2023-07-03T14:00:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-05T13:03:52Z

@engcom-Hotel functional failed tests do not refer to edits from the PR, kindly check again.
Thanks!

engcom-Hotel · 2023-07-06T06:15:55Z

Hello @aasim110,

Thanks for the reply!

Yes, I checked it again and it seems the functional test failures are flaky. But please add some automated tests to cover this fix.

Thanks

aasim110 · 2023-07-06T06:32:26Z

@engcom-Hotel there is no need to add automated tests for this case because this fix will update the product name with the child SKU and the product name is already available in Test cases.

engcom-Hotel · 2023-07-11T12:24:30Z

Hello @aasim110,

I agree with your point, we don't require any automated tests here. Hence moving this PR for testing.

Thanks

engcom-Lima · 2023-07-13T06:45:37Z

@magento run all tests

magento-automated-testing · 2023-07-13T06:45:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Lima · 2023-07-13T10:22:59Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

Enable PayPal Express Checkout [sandbox or live, the result is the same so just do sandbox for this test]
Enable "Transfer Cart Line Items"
Enable "PayPal Guest Checkout"
Submit the Order.
Check PayPal transactions in the PayPal sandbox account (not Magento)

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing

engcom-Echo · 2023-07-14T04:46:29Z

@magento run Unit Tests, WebAPI Tests,Integration Tests,Functional Tests EE,Functional Tests CE

magento-automated-testing · 2023-07-14T04:46:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-07-14T06:53:39Z

@magento run WebAPI Tests,Integration Tests,Unit Tests

magento-automated-testing · 2023-07-14T06:53:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-07-14T09:01:55Z

Functional Tests CE, Functional Tests EE are different on last two run on same commit.
Functional Tests CE
Run1

Run2

Functional Tests EE
Run1

Run2

And Integration Tests failure are not related to the PR.
Hence moving it to Merge In Progress

m2-community-project bot added the Progress: pending review label Jun 5, 2023

engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jun 6, 2023

aasim110 force-pushed the asym-paypal branch from 8ffe268 to 1972709 Compare June 6, 2023 16:21

aasim110 force-pushed the asym-paypal branch from 1972709 to 0124c18 Compare June 9, 2023 14:02

engcom-Hotel self-requested a review July 11, 2023 12:24

engcom-Hotel approved these changes Jul 11, 2023

View reviewed changes

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: needs update Progress: ready for testing labels Jul 11, 2023

Merge branch '2.4-develop' into asym-paypal

2bfd915

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Jul 13, 2023

engcom-Echo self-assigned this Jul 14, 2023

m2-community-project bot added Progress: ready for testing Progress: extended testing and removed Progress: extended testing Progress: ready for testing labels Jul 14, 2023

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jul 14, 2023

magento-devops-reposync-svc merged commit b4bcdc1 into magento:2.4-develop Aug 31, 2023

Added: SKU with configurable, group, bundle product Title #37578

Added: SKU with configurable, group, bundle product Title #37578

Uh oh!

Conversation

aasim110 commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jun 5, 2023

aasim110 commented Jun 5, 2023

magento-automated-testing bot commented Jun 5, 2023

aasim110 commented Jun 5, 2023

magento-automated-testing bot commented Jun 5, 2023

aasim110 commented Jun 5, 2023

magento-automated-testing bot commented Jun 5, 2023

aasim110 commented Jun 6, 2023

magento-automated-testing bot commented Jun 6, 2023

aasim110 commented Jun 6, 2023

magento-automated-testing bot commented Jun 6, 2023

aasim110 commented Jun 7, 2023

magento-automated-testing bot commented Jun 7, 2023

aasim110 commented Jun 7, 2023

magento-automated-testing bot commented Jun 7, 2023

aasim110 commented Jun 7, 2023

magento-automated-testing bot commented Jun 7, 2023

aasim110 commented Jun 7, 2023

magento-automated-testing bot commented Jun 7, 2023

aasim110 commented Jun 8, 2023

magento-automated-testing bot commented Jun 8, 2023

aasim110 commented Jun 8, 2023

magento-automated-testing bot commented Jun 8, 2023

aasim110 commented Jun 9, 2023

magento-automated-testing bot commented Jun 9, 2023

aasim110 commented Jun 9, 2023

magento-automated-testing bot commented Jul 3, 2023

aasim110 commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

engcom-Hotel commented Jul 6, 2023

aasim110 commented Jul 6, 2023

engcom-Hotel commented Jul 11, 2023

engcom-Lima commented Jul 13, 2023

magento-automated-testing bot commented Jul 13, 2023

engcom-Lima commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✔️ QA Passed

engcom-Echo commented Jul 14, 2023

magento-automated-testing bot commented Jul 14, 2023

engcom-Echo commented Jul 14, 2023

magento-automated-testing bot commented Jul 14, 2023

engcom-Echo commented Jul 14, 2023

aasim110 commented Jun 5, 2023 •

edited

Loading

aasim110 commented Jul 5, 2023 •

edited

Loading

engcom-Lima commented Jul 13, 2023 •

edited

Loading