Skip to content

Fixed: $row() undefined issue while inline edit after delete item from database #37560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2023
Merged

Fixed: $row() undefined issue while inline edit after delete item from database #37560

merged 4 commits into from
Aug 31, 2023

Conversation

aasim110
Copy link
Contributor

@aasim110 aasim110 commented May 30, 2023 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes CMS Page && CMS Block edit save error #37525

Manual testing scenarios (*)

1 Go Cms page list
2 Inline Edit Select the last two or three columns, and make sure the last column selected
image
3 open another window delete one of the three columns (not the last column) or delete the column in database
image
4 then save those columns will cause error
image
5 remove the error column
image
6 save another column (including the last one column), a loading error occurred. still loading
image
7 The problem same happened in CMS Block with the same steps
image

Questions or comments

  1. Afrer commit changes continues loading issue has been resolved.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant
Copy link

m2-assistant bot commented May 30, 2023

Hi @aasim110. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.
@aasim110
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento please run Functional Tests EE
@aasim110 aasim110 changed the title Fixed: undefined issue Fixed: $row() undefined issue while inline edit after delete item from database May 31, 2023
@aasim110
Copy link
Contributor Author

aasim110 commented May 31, 2023 •
edited
Loading

Hey @magento-engcom-team, @engcom-Bravo
Can someone else please check this?
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented May 31, 2023 •
edited
Loading

Hi @aasim110,
please add the steps to reproduce, an actual and expected result sections to issue description.
@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 31, 2023
@aasim110
Copy link
Contributor Author

aasim110 commented May 31, 2023 •
edited
Loading

Hi @ihor-sviziev I've updated the description.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 1, 2023

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 1, 2023 •
edited
Loading

Hi @ihor-sviziev I checked the logs and found that the error related to the Functional test B2B,
Error: in this file /var/www/html/dev/tests/integration/testsuite/Magento/NegotiableQuote/Cron/ExpireQuoteTest.php:148

So NegotiableQuote and its integration within the B2B suite, which serves as an add-on to our Enterprise offering. I must admit that I am somewhat uncertain about the necessity of functional and integration tests for both the Enterprise Edition (EE) and B2B when submitting a pull request to the Open Source repository. Could we explore the possibility of running solely the Open Source tests instead?

Your clarification on this matter would be greatly appreciated. Please let me know if there are any additional details or considerations that I should be aware of.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 2, 2023

@magento run integration tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 2, 2023

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 2, 2023

@magento run Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 3, 2023

@magento run Functional Tests CE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 3, 2023

@magento run Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 3, 2023

@magento run Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

aasim110 commented Jun 4, 2023

@magento run Functional Tests EE
@engcom-Echo
Copy link
Contributor

@magento run Unit Tests,Integration Tests,Functional Tests EE,Functional Tests CE,Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Static Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Static Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE ,Functional Tests CE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

Failing functional test are not related to this PR.
Hence Moving to merge in progress.
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B,Functional Tests EE,Integration Tests,Static Tests,Unit Tests ,WebAPI Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

Functional Tests EE failure are different on last two run on same commit. Other build failure are not related to PR changes.
Functional Tests EE
Run1
37560-ee

Run2
Screenshot 2023-08-18 at 12 33 16 PM
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 29f28ef into magento:2.4-develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community
10 participants
@aasim110 @ihor-sviziev @manavluhar @engcom-Hotel @engcom-Charlie @engcom-Lima @engcom-Echo @sinhaparul @engcom-Bravo @magento-devops-reposync-svc