#27504 fix joinprocessor behavior with consecutive calls #37550
Conversation
| Hi @fgerodez. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
| @magento run all tests |
| The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
engcom-Hotel added the Priority: P1 
| @magento run all tests |
| The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
| @magento run all tests |
| The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
m2-community-project bot added Progress: review and removed Progress: pending review labels 
There was a problem hiding this comment.
Hello @fgerodez
Thank you for your contribution
Could you please check my suggestion and fix copyright?
Thank you in advance.
...ion/testsuite/Magento/Framework/Api/SearchCriteria/CollectionProcessor/JoinProcessorTest.php Show resolved Hide resolved
m2-community-project bot added Progress: needs update and removed Progress: review labels …iteria/CollectionProcessor/JoinProcessorTest.php Co-authored-by: Andrii Beziazychnyi <a.beziazychnyi@atwix.com>
| @magento run all tests |
| @magento run WebAPI Tests, Functional Tests CE, Functional Tests EE |
m2-community-project bot added the Priority: P2 
| @magento run all tests |
| @magento run all tests |
| @magento run Functional Tests B2B, Functional Tests EE |
1 similar comment
| @magento run Functional Tests B2B, Functional Tests EE |
| Failing tests seem flaky and these are known issues. Therefore, I am moving the PR to Merge in Progress. Build Result Functional Tests EE: Known issue : |
| Hi @fgerodez and @andrewbess, Thank you for the contribution! As the review is pending, moving it back to Pending review. Thank you! |
| @magento run all tests |
engcom-Hotel added the Triage: Dev.Experience 
There was a problem hiding this comment.
Hello @fgerodez,
Thanks for the contribution!
Please fix the failed automated tests, specifically static test, and look into the review comments below.
Thanks
| class JoinProcessorTest extends TestCase | ||
| { | ||
| /** | ||
| * @var \Magento\Framework\ObjectManagerInterface |
There was a problem hiding this comment.
This qualifier can be replaced with an import. Import the ObjectManagerInterface and use it as below:
| * @var \Magento\Framework\ObjectManagerInterface | |
| * @var ObjectManagerInterface |
| | ||
| protected function setUp(): void | ||
| { | ||
| $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); |
There was a problem hiding this comment.
Same here
| $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); | |
| $this->objectManager = Bootstrap::getObjectManager(); |
| | ||
| $collection1 = $this->getMockBuilder(AbstractDb::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMockForAbstractClass(); |
There was a problem hiding this comment.
The getMockForAbstractClass method has been deprecated, please use alternate method.
| | ||
| $collection2 = $this->getMockBuilder(AbstractDb::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMockForAbstractClass(); |
There was a problem hiding this comment.
The getMockForAbstractClass method has been deprecated, please use alternate method.
| @magento run all tests |
@engcom-Hotel: I have implemented the suggested changes and fixed the integration failures. Moving it back to Pending Review. NOTE: The failed integration tests are not related to the PR changes and can also be seen in other PRs. |
m2-community-project bot added Progress: ready for testing and removed Progress: review labels | @magento run Integration Tests, Functional Tests EE |
| @magento run all tests |
| @magento run all tests |
| @magento run Unit Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B |
magento-devops-reposync-svc merged commit c93b59c into magento:2.4-develop 
Description (*)
When a JoinProcessor is called multiple times during a request the join definitions are only applied the first time. Subsequent calls will leave the collections unmodified.
Fixed Issues (if relevant)
Contribution checklist (*)