Skip to content

Fixed issue Add to Wishlist with product custom option file upload not working Magento 2.4.6 #37437 #37448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2025
Merged

Fixed issue Add to Wishlist with product custom option file upload not working Magento 2.4.6 #37437 #37448

merged 2 commits into from
Feb 17, 2025

Conversation

rostilos
Copy link
Contributor

@rostilos rostilos commented May 1, 2023

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Add to Wishlist with product custom option file upload not working Magento 2.4.6 #37437

Manual testing scenarios (*)

  1. Create a simple product
  2. Add a custom option file and text
  3. Options should be required.
    234768126-aedf846c-916e-4ef7-912b-19825ddb1d54
  4. Now go to the front end, log in customer, and open the product page.
  5. Upload file and add text value
  6. Now click on add to wishlist

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2023

Hi @rostilos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 1, 2023
@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels May 1, 2023
@rostilos
Copy link
Contributor Author

rostilos commented May 1, 2023

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@rostilos
Copy link
Contributor Author

rostilos commented May 1, 2023

@magento run Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@rostilos
Copy link
Contributor Author

rostilos commented May 5, 2023

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@rostilos
Copy link
Contributor Author

@magento run Functional Tests B2B, Integration Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label May 19, 2023
@engcom-Hotel
Copy link
Contributor

@magento give me test instance
@magento-deployment-service
Copy link

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.
@magento-deployment-service
Copy link

Hi @engcom-Hotel, here is your Magento Instance: https://09a3042d95d672bd86d1779f206d73c2.instances-prod.magento-community.engineering
Admin access: https://09a3042d95d672bd86d1779f206d73c2.instances-prod.magento-community.engineering/admin_2ce9
Login: 295b6f1f
Password: 62079f5a8e85
@engcom-Hotel
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

@magento give me 2.4-develop instance
@magento-deployment-service
Copy link

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.
@magento-deployment-service
Copy link

Hi @engcom-Hotel, here is your Magento Instance: https://6e53aa9f4c77407ca4330a6f6d74686b.instances-prod.magento-community.engineering
Admin access: https://6e53aa9f4c77407ca4330a6f6d74686b.instances-prod.magento-community.engineering/admin_7621
Login: b6b2ef02
Password: 98506fad41b9
engcom-Hotel
engcom-Hotel requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rostilos,

Thanks for the contribution!

The changes seem good to me. But I believe we can cover the changes with some automated tests for e.g. MFTF.

Thanks
@rostilos
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@rostilos
Copy link
Contributor Author

@engcom-Hotel Added test coverage for this fix.
Test case when item has 3 customizable options. This was done for the reason of not creating a new entity in the test, but to use an existing one ( The bug is reproduced even when there are 3 customizable options, since the cause is the same, you can double-check this )
@rostilos
Copy link
Contributor Author

@magento run Database Compare, Functional Tests CE
@engcom-Lima engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 24, 2023
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

  • Create a simple product
  • Add a custom option file and text
  • Options should be required.
  • Now go to the front end, log in customer, and open the product page.
  • Upload file and add text value
  • Now click on add to wishlist

Before: ✖️ Two products got added in the wishlist.

Screenshot 2023-05-24 at 4 52 00 PM

After: ✔️ Now only one product is added in the wishlist.

Screenshot 2023-05-24 at 4 53 31 PM

Build is failed. Hence, moving this PR to Extended Testing
@engcom-Echo engcom-Echo self-assigned this May 24, 2023
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

Functional Tests B2B build failure are different on last two run on same commit.
Run1
image

Run2
image

Hence moving it to Merge In Progress
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@rostilos
Copy link
Contributor Author

@engcom-Echo I've noticed a certain oddity. I see that the edits have been merged into the dev branch ( eaf24b2?diff=split ) , but the edit history of this PR is empty
@engcom-Charlie
Copy link
Contributor

@engcom-Echo I've noticed a certain oddity. I see that the edits have been merged into the dev branch ( eaf24b2?diff=split ) , but the edit history of this PR is empty

Hi @rostilos,

This PR is already merged in d4a9791. As after adding this this PR into mainline PR, we have added few commits of merging 2.4-dev into this, that is the reason it is still showing as in Open status.

Thank you!
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 9bb8c2f into magento:2.4-develop Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Community Picked PRs upvoted by the community QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope
8 participants
@rostilos @engcom-Hotel @engcom-Echo @engcom-Lima @engcom-Charlie @sinhaparul @magento-devops-reposync-svc @m2-github-services