Skip to content

Feature/php8.1 constructor property promotion wee graph ql #36975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 24, 2025
Merged

Feature/php8.1 constructor property promotion wee graph ql #36975

merged 7 commits into from
Feb 24, 2025

Conversation

leonhelmus
Copy link

@leonhelmus leonhelmus commented Mar 6, 2023 •
edited by m2-assistant bot
Loading

Description (*)

Replace allmost all properties with constructor property promotion in module wee graph ql:
https://stitcher.io/blog/constructor-promotion-in-php-8

  • Readable code
  • Make Magento less complex by removing properties which take up a lot of lines.
  • Imported all classes to make code more readable.
    I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Feature/php8.1 constructor property promotion wee graph ql #39309: Feature/php8.1 constructor property promotion wee graph ql
@l-helmus-youwe
Merge remote-tracking branch 'magento/2.4-develop' into feature/php8.…
6f1107c 
…1-constructor-property-promotion-wee-graph-ql
@l-helmus-youwe
Use constructor property promotion in module WeeeGraphQl
c8b2711 
Replace allmost all properties with constructor property promotion in module WeeeGraphQl: https://stitcher.io/blog/constructor-promotion-in-php-8 * Readable code * Make Magento less complex by removing properties which take up a lot of lines. * Imported all classes to make code more readable. I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).
@m2-assistant
Copy link

m2-assistant bot commented Mar 6, 2023

Hi @leonhelmus. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.
@leonhelmus
Copy link
Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 28, 2023
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review and removed Progress: ready for testing labels May 25, 2023
ihor-sviziev
ihor-sviziev requested changes May 25, 2023
View reviewed changes
@ihor-sviziev
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
ihor-sviziev
ihor-sviziev approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.
@engcom-Lima engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jun 1, 2023
@engcom-Dash engcom-Dash self-assigned this Sep 25, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests
@engcom-Dash
Copy link
Contributor

Hello @leonhelmus

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:
Install fresh Magento 2.4-develop

Steps to reproduce

  • Set up FPT(Fixed Product Taxes)
  • Fixed Product Taxes should be visible in products Graphql response.
  • Store config details for FPT should be visible in respective GraphQL response.

Before: ✖️
N/A

After: ✔️
image
image

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks
@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE
@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.
@magento magento deleted a comment from magento-automated-testing bot Sep 25, 2024
@engcom-Dash
Copy link
Contributor

Hello @leonhelmus, please sign CLA.
@leonhelmus
Copy link
Author

leonhelmus commented Sep 25, 2024 •
edited
Loading

@engcom-Dash I have now signed a CLA
@engcom-Dash
Copy link
Contributor

@magento run all tests
@engcom-Dash
Copy link
Contributor

@magento run all tests
@engcom-Dash
Copy link
Contributor

@magento run all tests
@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests EE, Functional Tests CE
@engcom-Dash
Copy link
Contributor

Moving to merge in progress.
image
@engcom-Dash
Copy link
Contributor

@magento create issue
@m2-assistant m2-assistant bot mentioned this pull request Oct 29, 2024
Closed
5 tasks
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 88090b7 into magento:2.4-develop Feb 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
7 participants
@leonhelmus @ihor-sviziev @engcom-Dash @engcom-Bravo @engcom-Lima @magento-devops-reposync-svc @l-helmus-youwe