Skip to content

Changes of GR(Greece) PostCode Pattern #36696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Changes of GR(Greece) PostCode Pattern #36696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0096b7
Changes of GR(Greece) PostCode Pattern
Vasudev-22 Jan 3, 2023
5a32d76
Merge branch '2.4-develop' into issue-36676
engcom-Lima Jun 16, 2023
f6751a0
Merge branch '2.4-develop' into issue-36676
Vasudev-22 Jul 19, 2023
b9dfdad
Merge branch '2.4-develop' into issue-36676
Vasudev-22 Aug 21, 2023
ea3c7d7
Merge branch '2.4-develop' into issue-36676
engcom-Lima Sep 14, 2023
16f212b
Fixed integration test fialure
engcom-Charlie Sep 15, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Directory/etc/zip_codes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
</zip>
<zip countryCode="GR">
<codes>
<code id="pattern_1" active="true" example="123 45">^[0-9]{3}\s[0-9]{2}$</code>
<code id="pattern_1" active="true" example="12345">^[0-9]{5}$</code>
</codes>
</zip>
<zip countryCode="GS">
Expand Down
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/Directory/Model/Country/Postcode/ValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function getPostcodesDataProvider()
['countryId' => 'GH', 'postcode' => 'GA18400'],
['countryId' => 'GN', 'postcode' => '123'],
['countryId' => 'GP', 'postcode' => '12345'],
['countryId' => 'GR', 'postcode' => '123 45'],
['countryId' => 'GR', 'postcode' => '12345'],
['countryId' => 'GS', 'postcode' => 'SIQQ 1ZZ'],
['countryId' => 'GT', 'postcode' => '12345'],
['countryId' => 'GU', 'postcode' => '12345'],
Expand Down