Fixed issue Billing & Shipping address the same checkbox is empty

app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontGuestCheckoutProceedToPaymentStepActionGroup.xml

@@ -10,9 +10,10 @@
  xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
  <actionGroup name="StorefrontGuestCheckoutProceedToPaymentStepActionGroup">
  <annotations>
- <description>Clicks next on Checkout Shipping step. Waits for Payment step</description>
+ <description>Waits for Shipping Section load. Clicks next on Checkout Shipping step. Waits for Payment step</description>
  </annotations>
 
+ <waitForElementClickable selector="{{CheckoutShippingGuestInfoSection.next}}" stepKey="waitForNextButtonClickable"/>
  <click selector="{{CheckoutShippingGuestInfoSection.next}}" stepKey="clickNext"/>
  <waitForElement selector="{{CheckoutPaymentSection.paymentSectionTitle}}" stepKey="waitForPaymentSectionLoaded" after="clickNext"/>
  <seeCurrentUrlMatches regex="~/checkout/?#payment~" stepKey="assertCheckoutPaymentUrl"/>

app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontSelectFirstShippingMethodActionGroup.xml

@@ -10,9 +10,10 @@
  xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
  <actionGroup name="StorefrontSelectFirstShippingMethodActionGroup">
  <annotations>
- <description>Select first shipping method.</description>
+ <description>Waits for Shipping Section load. Select first shipping method.</description>
  </annotations>
-
+
+ <waitForElementClickable selector="{{CheckoutShippingMethodsSection.next}}" stepKey="waitForShippingMethod"/>
  <click selector="{{CheckoutShippingMethodsSection.firstShippingMethod}}" stepKey="selectFirstShippingMethod"/>
  <waitForLoadingMaskToDisappear stepKey="waitForMaskDisappear"/>
  </actionGroup>

app/code/Magento/Checkout/Test/Mftf/Test/StorefrontGuestCheckoutWithSameShippingAndBillingAddressEnabledCheckboxTest.xml

@@ -0,0 +1,48 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+ <test name="StorefrontGuestCheckoutWithSameShippingAndBillingAddressEnabledCheckboxTest">
+ <annotations>
+ <features value="Checkout"/>
+ <stories value="My billing and shipping address are same checkbox should be checked by default"/>
+ <title value="My billing and shipping address are same checkbox should be checked by default"/>
+ <description value="Check that My billing and shipping address are same checkbox should be checked by default"/>
+ <severity value="AVERAGE"/>
+ <testCaseId value="AC-8596"/>
+ <group value="checkout"/>
+ </annotations>
+
+ <before>
+ <magentoCLI command="config:set {{EnableFlatRateConfigData.path}} {{EnableFlatRateConfigData.value}}" stepKey="enableFlatRate"/>
+ <createData entity="SimpleProduct2" stepKey="createProduct"/>
+ </before>
+
+ <after>
+ <deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
+ </after>
+
+ <actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openProductPage">
+ <argument name="productUrl" value="$createProduct.custom_attributes[url_key]$"/>
+ </actionGroup>
+ <actionGroup ref="AddToCartFromStorefrontProductPageActionGroup" stepKey="addToCartFromStorefrontProductPage">
+ <argument name="productName" value="$createProduct.name$"/>
+ </actionGroup>
+ <actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="goToCheckoutFromMinicart"/>
+ <actionGroup ref="GuestCheckoutFillNewShippingAddressActionGroup" stepKey="fillShippingSectionAsGuest">
+ <argument name="customer" value="CustomerEntityOne"/>
+ <argument name="address" value="CustomerAddressSimple"/>
+ </actionGroup>
+ <waitForElementVisible selector="{{CheckoutShippingSection.next}}" time="30" stepKey="waitForNextButton"/>
+ <click selector="{{CheckoutShippingSection.next}}" stepKey="clickNext"/>
+ <waitForPageLoad stepKey="waitForPaymentLoading"/>
+ <waitForElementVisible selector="{{CheckoutPaymentSection.paymentSectionTitle}}" time="30" stepKey="waitForPaymentSectionLoaded"/>
+ <seeCheckboxIsChecked selector="{{CheckoutPaymentSection.billingAddressNotSameCheckbox}}" stepKey="shippingAndBillingAddressIsSameChecked"/>
+ </test>
+</tests>

app/code/Magento/Checkout/Test/Mftf/Test/StorefrontPersistentDataForGuestCustomerWithPhysicalQuoteTest.xml

@@ -67,6 +67,7 @@
  <fillField selector="{{CheckoutShippingGuestInfoSection.regionInput}}" userInput="" stepKey="changeStateProvinceField"/>
  <fillField selector="{{CheckoutShippingGuestInfoSection.postcode}}" userInput="KW1 7NQ" stepKey="changeZipPostalCodeField"/>
  <!-- 8. Change shipping rate, select Free Shipping -->
+ <waitForElementClickable selector="{{CheckoutShippingMethodsSection.shippingMethodFreeShipping}}" stepKey="waitForFreeShippingShippingMethod"/>
  <checkOption selector="{{CheckoutShippingMethodsSection.checkShippingMethodByName('Free Shipping')}}" stepKey="checkFreeShippingAsShippingMethod"/>
  <!-- 9. Fill other fields -->
  <actionGroup ref="StorefrontFillGuestShippingInfoActionGroup" stepKey="fillOtherFieldsInCheckoutShippingSection"/>

app/code/Magento/Checkout/view/frontend/web/js/model/cart/estimate-service.js

@@ -72,6 +72,8 @@ define([
  cartCache.set('totals', quote.getTotals());
  }
  }
+ // unset loader on shipping rates list
+ shippingService.isLoading(false);
  },
 
  /**

app/code/Magento/Checkout/view/frontend/web/js/model/shipping-rates-validator.js

@@ -17,6 +17,7 @@ define([
  'mage/translate',
  'uiRegistry',
  'Magento_Checkout/js/model/shipping-address/form-popup-state',
+ 'Magento_Checkout/js/model/shipping-service',
  'Magento_Checkout/js/model/quote'
 ], function (
  $,
@@ -28,7 +29,8 @@ define([
  defaultValidator,
  $t,
  uiRegistry,
- formPopUpState
+ formPopUpState,
+ shippingService
 ) {
  'use strict';
 
@@ -146,6 +148,8 @@ define([
  }, delay);
 
  if (!formPopUpState.isVisible()) {
+ // Prevent shipping methods showing none available whilst we resolve
+ shippingService.isLoading(true);
  clearTimeout(self.validateAddressTimeout);
  self.validateAddressTimeout = setTimeout(function () {
  self.validateFields();

app/code/Magento/Shipping/Test/Mftf/Test/StorefrontAssertShippingPricesPresentAfterApplyingCartRuleTest.xml

@@ -82,6 +82,7 @@
  </actionGroup>
  <see selector="{{CheckoutShippingMethodsSection.shippingRatePriceByName('Fixed')}}" userInput="$5.00" stepKey="assertFlatRatedMethodPrice"/>
  <see selector="{{CheckoutShippingMethodsSection.shippingRatePriceByName('Table Rate')}}" userInput="$7.99" stepKey="assertTableRatedMethodPrice"/>
+ <waitForElementClickable selector="{{CheckoutShippingMethodsSection.shippingMethodFlatRate}}" stepKey="waitForFlatRateShippingMethod"/>
  <click selector="{{CheckoutShippingMethodsSection.checkShippingMethodByName('Flat Rate')}}" stepKey="selectFlatRateShippingMethod"/>
  <actionGroup ref="StorefrontCheckoutClickNextButtonActionGroup" stepKey="goToPaymentStep"/>
  <actionGroup ref="StorefrontApplyDiscountCodeActionGroup" stepKey="applyCoupon">

dev/tests/js/jasmine/tests/app/code/Magento/Checkout/frontend/js/model/cart/estimate-service.test.js

@@ -41,6 +41,7 @@ define([
  },
  'Magento_Checkout/js/model/shipping-service': {
  setShippingRates: function () {},
+ isLoading: ko.observable(),
  getShippingRates: function () {
  return ko.observable(rates);
  }