Skip to content

Fix for issue 27474 #36030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Aug 31, 2023
Merged

Fix for issue 27474 #36030

merged 38 commits into from
Aug 31, 2023

Conversation

topanok
Copy link
Contributor

@topanok topanok commented Aug 25, 2022

Description (*)

Since this behavior occurs both on the invoice page and on the shipment and credit memo pages, it was decided to add an info block to these pages. The page headers were also changed to bring them to the appropriate view, because only the number was displayed on the invoice and shipment page, and View Memo on the credit memo page.

Fixed Issues (if relevant)

  1. Fixes In the invoice it is not shown, if the invoice email has been sent or not #27474

Manual testing scenarios (*)

  1. Create an order
  2. Create the corresponding invoice in the backend
  3. Create the corresponding shipment in the backend
  4. Create the corresponding crdit memo in the backend
  5. Open the invoice or shipment or credit memo in the backend and take a look at the new Info block with rwith the relevant information about the email and so on

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2022

Hi @topanok. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Aug 25, 2022
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 25, 2022
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@topanok
Copy link
Contributor Author

topanok commented Aug 26, 2022

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@topanok
Copy link
Contributor Author

topanok commented Aug 26, 2022

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@topanok
Copy link
Contributor Author

topanok commented Aug 27, 2022

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@topanok
Copy link
Contributor Author

topanok commented Aug 27, 2022

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@topanok
Copy link
Contributor Author

topanok commented Aug 27, 2022

@magento run Functional Tests B2B, Integration Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@topanok
Copy link
Contributor Author

topanok commented Aug 29, 2022

Clarifications are needed from the reviewer on the Semantic Version Checker test
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo engcom-Echo removed their assignment Aug 18, 2023
@topanok
Copy link
Contributor Author

topanok commented Aug 21, 2023

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

Hello @topanok,

It seems you are working on this PR. Can you please confirm if you are working on fixing its build failures?

Thanks
@engcom-Hotel
Copy link
Contributor

@magento run Database Compare, Unit Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

Moving this PR for testing after fixing the Functional tests failures.
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Moving PR to Merge in progress
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 0a5218e into magento:2.4-develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope
10 participants
@topanok @engcom-Hotel @engcom-Echo @engcom-Lima @engcom-Charlie @sdzhepa @sinhaparul @magento-devops-reposync-svc @m2-github-services @glo24157