Upgrade PHPStan to version 1.5

[shochdoerfer]

Description (*)

PHPStan 1.5 was released yesterday. This PR upgrades PHPStand 1.4.9 to 1.5.0.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Upgrade PHPStan to version 1.5 #35315: Upgrade PHPStan to version 1.5

[m2-assistant]

Hi @shochdoerfer. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[nuzil]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[andrewbess]

Hello @shochdoerfer
Thank you for your contribution here
Could you please resolve merge conflicts
Thank you in advance.

[sdzhepa]

@magento create issue

[shochdoerfer]

@andrewbess should we also upgrade to the latest PHPStand version (1.5.6)?

[andrewbess]

Hello @shochdoerfer
Please update your branch from the mainline (2.4-develop) and just upgrade phpstan/phpstan composer dependency to the 1.5.6 using constraint "~1.5.6".
I will import your PR into magento-commerce and merge it ASAP.
Thank you in advance.

[hostep]

Shouldn't we change the constraint from ~1.5.0 to ^1.5.0? Because version 1.6.0 has already been announced. Otherwise we'll have to send in a PR every two months or so ...

So the end user is not depending on Adobe/Magento to determine the version of phpstan to use on a project and can upgrade themselves to a newer version if they wish so.

[andrewbess]

Hello everyone
Thank you @hostep for your recommendation

@shochdoerfer Let's use ^1.5.6 constraint for this extension
Please update the phpstan/phpstan composer dependency with constraint.

Thank you in advance.

[shochdoerfer]

@andrewbess done!

[andrewbess]

Hello @shochdoerfer
Thank you for your contribution
This PR imported into magento-commerce repo
Please don't change it.