Skip to content

Fix Wrong ratings at second Catalog Product List at cms page widget #33867 #33898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2022
Merged

Fix Wrong ratings at second Catalog Product List at cms page widget #33867 #33898

merged 5 commits into from
Jun 11, 2022

Conversation

Kannakiraj123
Copy link
Contributor

Description (*)

1.In review phtml use "queryselector".its pointing first element only.Thats why this issue happened.
2.I changed "queryselector" to "queryselectorAll" .its pointing to all element of each product.So at second catalog list have same data like first catalog list

Related Pull Requests

Fixed Wrong ratings at second Catalog Product List at cms page widget

Fixed Issues (if relevant)

  1. Fixes Wrong ratings at second Catalog Product List  #33867
@m2-assistant
Copy link

m2-assistant bot commented Aug 24, 2021

Hi @Kannakiraj123. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 24, 2021
@Kannakiraj123
Copy link
Contributor Author

@magento give me test instance
@magento-deployment-service
Copy link

Hi @Kannakiraj123. Thank you for your request. I'm working on Magento instance for you.
@Kannakiraj123
Copy link
Contributor Author

@magento give me test instance
@magento-deployment-service
Copy link

Hi @Kannakiraj123. Thank you for your request. I'm working on Magento instance for you.
@magento-deployment-service
Copy link

Hi @Kannakiraj123, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.
@magento-deployment-service
Copy link

Hi @Kannakiraj123, here is your Magento Instance: https://28f4bec5bce4f03ef7bbdbf9c4f479dc.instances.magento-community.engineering
Admin access: https://28f4bec5bce4f03ef7bbdbf9c4f479dc.instances.magento-community.engineering/admin_5fe1
Login: 72486a9a
Password: e9c7f13e873f
@bgorski bgorski self-requested a review August 24, 2021 19:26
@bgorski bgorski self-assigned this Aug 24, 2021
@Kannakiraj123
Copy link
Contributor Author

@magento give me test instance
@magento-deployment-service
Copy link

Hi @Kannakiraj123. Thank you for your request. I'm working on Magento instance for you.
@magento-deployment-service
Copy link

Hi @Kannakiraj123, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.
@Kannakiraj123
Copy link
Contributor Author

Hi @Kannakiraj123, here is your Magento Instance: https://28f4bec5bce4f03ef7bbdbf9c4f479dc.instances.magento-community.engineering
Admin access: https://28f4bec5bce4f03ef7bbdbf9c4f479dc.instances.magento-community.engineering/admin_5fe1
Login: 72486a9a
Password: e9c7f13e873f

hi,This is not correctly fixed.I updated another one commit.@magento give me test instance
@magento-deployment-service
Copy link

Hi @Kannakiraj123. Thank you for your request. I'm working on Magento instance for you.
@magento-deployment-service
Copy link

Hi @Kannakiraj123, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.
@bgorski
Copy link
Contributor

bgorski commented Aug 24, 2021

@Kannakiraj123 thank you for the contribution! In the meantime, can you sign the Adobe Contributor License Agreement? You can find it here: https://opensource.adobe.com/cla.html
It's the necessary 1st step to process your pull request.
@Kannakiraj123
Copy link
Contributor Author

@bgorski I signed.but it's not updated here
@Kannakiraj123
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@Kannakiraj123
Copy link
Contributor Author

@magento give me test instance
@engcom-Lima
Copy link
Contributor

Will look into the build failures and work accordingly
Thanks!
@engcom-Lima
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B, WebAPI Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B, WebAPI Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@engcom-Lima
Copy link
Contributor

Hi @Kannakiraj123,
Thanks for the contribution
The build failures are now addressed and all the builds have passed successfully hence moving the PR ahead.

Thanks!
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit ba31b4f into magento:2.4-develop Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: View Partner: EY partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4

9 participants

@Kannakiraj123 @bgorski @vpodorozh @magento-engcom-team @engcom-Alfa @engcom-Hotel @engcom-Lima @sidolov @magento-devops-reposync-svc