- Notifications
You must be signed in to change notification settings - Fork 9.4k
Correct spelling of variables for customer address #32815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling of variables for customer address #32815
Conversation
Hi @fredden. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
app/code/Magento/Customer/view/frontend/templates/address/book.phtml Outdated Show resolved Hide resolved
app/code/Magento/Customer/view/frontend/templates/address/book.phtml Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests looks not related to changes from this PR.
Hi @ihor-sviziev, thank you for the review. |
@magento create issue |
…tomer-address-grid
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
QA is not required for this change since it only updates the variable name. Builds are failing so moving it to extended testing. |
@magento run all tests |
@magento run all tests |
c73145e
into magento:2.4-develop
Description
These two templates are often overridden in child themes. Whenever they're copied over for modification, our code reviews tend to pick up the incorrect spelling of these variables. Let's get these fixed here so we don't have to keep fixing them locally.
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
There are no functional changes in this pull request, so only limited testing will be necessary.
Questions or comments
None
Contribution checklist (*)
Resolved issues: