Skip to content

[Checkout] Depend directives updated in failed payment email template #32511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2024
Merged

[Checkout] Depend directives updated in failed payment email template #32511

merged 4 commits into from
Jul 4, 2024

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Mar 16, 2021 •
edited by m2-assistant bot
Loading

Description (*)

Updated the depend directives in the failed payment email template. If the order is virtual doesn't require showing the shipping address and the shipping method.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Create virtual product
  2. Add trigger failed payment email logic in exception on any payment
  3. Placed Order with wrong details
  4. Receive failed payment email without shipping address & shipping method

Questions or comments

Please let me know your feedback's to improve this PR.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] [Checkout] Depend directives updated in failed payment email template #32781: [Checkout] Depend directives updated in failed payment email template
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2021

Hi @srsathish92. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
@srsathish92
Copy link
Contributor Author

@magento run all tests
@srsathish92
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,WebAPI Tests
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Mar 24, 2021
ihor-sviziev
ihor-sviziev approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved!

I believe we don't have any tests for emails, so marked tests as not required.
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8969 has been created to process this Pull Request
@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 25, 2021
@srsathish92
Copy link
Contributor Author

@magento create issue
@m2-assistant m2-assistant bot mentioned this pull request Apr 19, 2021
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-8969 has been created to process this Pull Request
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Aug 12, 2021
@engcom-Delta engcom-Delta self-assigned this Mar 7, 2024
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label May 21, 2024
@engcom-Charlie engcom-Charlie self-assigned this May 23, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Static Tests, WebAPI Tests
1 similar comment
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Static Tests, WebAPI Tests
@engcom-Charlie
Copy link
Contributor

@magento run all tests
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented May 31, 2024 •
edited
Loading

The functional B2B failures in latest 2 builds are seems to be flaky and not part of this PR.

The rest of the test failures are having known issues.

  1. ACQE-6350- AdminCreateDraftQuoteFromQuoteGridPageWithMultipleStoresTest
  2. ACQE-6590- AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest
  3. ACQE-6648-StorefrontUpdateCustomerAddressBelgiumTest

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32511/209eb3eddaa259a57a3af8b025e7b295/Functional/allure-report-b2b/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32511/434c25b13af44d34c448537bce4eaf7f/Functional/allure-report-b2b/index.html#categories
image
@engcom-Charlie
Copy link
Contributor

Some of the functional EE failures seems to be flaky and rest are the known issues.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32511/a59a13d47155402e0e5e0058de1532f7/Functional/allure-report-ee/index.html
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32511/4a9f3d63236b10c04ff8c5188e7e527f/Functional/allure-report-ee/index.html
image

Known issues:

  1. ACQE-6331- StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest
  2. ACQE-6523- AdminReorderWithCatalogPriceRuleDiscountTest
@engcom-Charlie
Copy link
Contributor

Some of the WebAPI test failures are flaky eg. testCmsSingleBlockResolverCacheAndInvalidationAsGuest. Its not related to this PR and rest of them are known failures. Hence moving the PR to Merge in Progress.

  1. #ACP2E-3082: testSendNegotiableQuoteCannotResend
  2. #ACP2E-3083: testGetCustomerDescendingSortedOrders
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 32b9733 into magento:2.4-develop Jul 4, 2024
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 21, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Checkout Partner: ITG Commerce partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Progress: pending review Project: Community Picked PRs upvoted by the community Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
10 participants
@srsathish92 @magento-engcom-team @engcom-Delta @engcom-Charlie @Den4ik @ihor-sviziev @gabrieldagama @sidolov @sinhaparul @magento-devops-reposync-svc