module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.

[sanganinamrata]

Description (*)

Removed <module name=“Magento_Catalog”/> dependency from Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. as those modules are already dependent on Magento_ConfigurableProduct, which is then dependent on Magento_Catalog. So need to add those dependencies.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. #30675: module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.

[m2-assistant]

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogyar]

@magento run all tests

[sidolov]

@magento create issue

[rogyar]

@magento run Functional Tests EE

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8418 has been created to process this Pull Request

[engcom-Bravo]

Manual QA not applicable. Moved to Extended Testing column

[engcom-Delta]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenario:

Go to the paths

1. app/code/Magento/ConfigurableProductGraphQl/etc/module.xml
2. app/code/Magento/MsrpConfigurableProduct/etc/module.xml
3. app/code/Magento/NewRelicReporting/etc/module.xml
4. app/code/Magento/Swatches/etc/module.xml
5. Verify Removed dependency

Before: ✖️ 

After: ✔️  

Builds are failed. Hence, moving this PR to Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Integration Tests, Functional Tests EE, Functional Tests B2B

[engcom-Dash]

The Functional B2B test failures are different in recent 2 builds with a known issue. Seems to be flaky, hence moving it to Merge in Progress.
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/067553cfed1c9017791005855fe35b94/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/a076bf0024a61f95/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/ef8c95512fa8569aba463b1886e207a8/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/a67940e2aee757d1/

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Moving this PR to Extended Testing to resolve the static failures.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Dash]

The consistent failure in Functional B2B is a known issue and JIRA is open for the same.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/25e3303c42c45567cb7e4ecf24ab819c/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/4dd6df18e5406b1dee5b8687f9d38daa/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490

One consistent failure in Functional CE is a known issue and JIRA is open for the same. The other failures are inconsistent. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/d6ecce710d1cffffe8a81ab9c7c53431/Functional/allure-report-ce/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/1dbce1e6a3e118e18c3ffca997a60841/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: StorefrontDeleteSimpleAndVirtualProductFromMiniShoppingCartTest ACQE-8560

The consistent failure in Functional EE is a known issue and JIRA is open for the same.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/be2c3fa87d2ff822d5211edd024c54f4/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/630ffe67f9b82cd857a41f1350286e49/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490

Hence moving this PR in Merge In Progress.