Skip to content

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Jan 27, 2020

Description (*)

[Fedex] covered Generic.php by unit test & changed the deprecated class Option\ArrayInterface into Data\OptionSourceInterface
Path: app/code/Magento/Fedex/Model/Source/Generic.php

Manual testing scenarios (*)

vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Fedex/Test/Unit/Model/Source/GenericTest.php

Questions or comments

If any please let me know your feedback

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@srsathish92 srsathish92 requested a review from YevSent as a code owner January 27, 2020 11:29
@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Jan 27, 2020
@ghost ghost assigned nuzil Jan 27, 2020
@nuzil nuzil added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-6695 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get through the comments.

@ghost ghost assigned lbajsarowicz Jan 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6695 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7 participants